Add patches for block-level quant in theora, -O2 on build, and statically link pthread on Windows

Add patches for block-level quant in theora, -O2 on build, and statically link pthread on Windows

For Theora changes, also includes 4 patches that fix various decoder crash bugs in theora due to bad clamping of values, or forgetting to check return codes.

There is a build settings patch to use -O2 for all platforms instead of -O3, and to statically link pthreads on windows. This reduces the produced binary sizes, and decreases CPU usage by like 10% on windows.

BUG=17174
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=22821

[awong, 2009-08-07 01:00:24]

Here's the changes needed to add basic block-quant support + a couple of
suggested theora bug fixes thrown in.  I've looked through the patches and they
seem solid, or at the very least, only theora related. :)

[fbarchard, 2009-08-07 17:10:03]

looks okay, but I'd like to run some tests.

[awong, 2009-08-07 21:26:05]

Added in patches for frank's static ptherads on windows + -O2 during build.  Let
me know if it looks good.

[fbarchard, 2009-08-07 21:48:34]

we need to code patch:
http://ffmpeg.arrozcru.org/wiki/images/d/dd/Ffmpeg_r15966_static_pthreads.diff

http://codereview.chromium.org/164120/diff/16/1010
File README.chromium (right):

http://codereview.chromium.org/164120/diff/16/1010#newcode21
Line 21: distribution, and lowers the total size of the binaries.
we should include some instructions on pthread.
basically follow these instructions
http://ffmpeg.arrozcru.org/wiki/index.php?title=Pthreads
apply andrews patch to make it build on mingw.  Then
make clean GC-static
from a msys window
Then copy the libpthreadGC2.a pthread.h sched.h into mingw folders.
delete this C:\msys\1.0\bin\pthreadGC2.dll
update these:
C:\msys\1.0\include\pthread.h
C:\msys\1.0\lib\libpthreadGC2.a
C:\msys\1.0\mingw32\include\pthread.h
C:\msys\1.0\mingw32\lib\libpthread.a
TODO(fbarchard): build with O2

http://codereview.chromium.org/164120/diff/16/1010#newcode37
Line 37: patch -p1 < ../static_pthread_O2.patch
Sorry I forgot theres also a code patch.
These are the original instructions
http://ffmpeg.arrozcru.org/wiki/images/d/dd/Ffmpeg_r15966_static_pthreads.diff
We need the change in libavcodec/allcodecs.c

http://codereview.chromium.org/164120/diff/16/1016
File static_pthread_O2.patch (right):

http://codereview.chromium.org/164120/diff/16/1016#newcode18
Line 18: +        add_cflags -DPTW32_STATIC_LIB -O2
nit O2 isn't necessary

[scherkus (not reviewing), 2009-08-07 22:46:22]

http://codereview.chromium.org/164120/diff/16/1010
File README.chromium (right):

http://codereview.chromium.org/164120/diff/16/1010#newcode19
Line 19: a modification that statically links pthreadsG2 into the avcodec.dll on
an
pthreadsG2 -> pthreadGC2
avcodec.dll -> avcodec-52.dll

perhaps "into the" -> "into" ?

http://codereview.chromium.org/164120/diff/16/1010#newcode21
Line 21: distribution, and lowers the total size of the binaries.
On 2009/08/07 21:48:34, fbarchard wrote:
> we should include some instructions on pthread.
> basically follow these instructions
> http://ffmpeg.arrozcru.org/wiki/index.php?title=Pthreads
> apply andrews patch to make it build on mingw.  Then
> make clean GC-static
> from a msys window
> Then copy the libpthreadGC2.a pthread.h sched.h into mingw folders.
> delete this C:\msys\1.0\bin\pthreadGC2.dll
> update these:
> C:\msys\1.0\include\pthread.h
> C:\msys\1.0\lib\libpthreadGC2.a
> C:\msys\1.0\mingw32\include\pthread.h
> C:\msys\1.0\mingw32\lib\libpthread.a
> TODO(fbarchard): build with O2

These instructions should be a part of the MinGW setup.  Frank, you'll have to
build + package up pthreads in a way that can be extracted into an msys
installation so that windows users can build using the proper build of pthreads.

[awong, 2009-08-07 23:07:03]

Committing for now.  If there are more changes, please feel free to reopen and
add more ocmments.

http://codereview.chromium.org/164120/diff/16/1010
File README.chromium (right):

http://codereview.chromium.org/164120/diff/16/1010#newcode19
Line 19: a modification that statically links pthreadsG2 into the avcodec.dll on
an
On 2009/08/07 22:46:22, scherkus wrote:
> pthreadsG2 -> pthreadGC2
> avcodec.dll -> avcodec-52.dll
> 
> perhaps "into the" -> "into" ?
> 

Done.

http://codereview.chromium.org/164120/diff/16/1010#newcode21
Line 21: distribution, and lowers the total size of the binaries.
On 2009/08/07 22:46:22, scherkus wrote:
> On 2009/08/07 21:48:34, fbarchard wrote:
> > we should include some instructions on pthread.
> > basically follow these instructions
> > http://ffmpeg.arrozcru.org/wiki/index.php?title=Pthreads
> > apply andrews patch to make it build on mingw.  Then
> > make clean GC-static
> > from a msys window
> > Then copy the libpthreadGC2.a pthread.h sched.h into mingw folders.
> > delete this C:\msys\1.0\bin\pthreadGC2.dll
> > update these:
> > C:\msys\1.0\include\pthread.h
> > C:\msys\1.0\lib\libpthreadGC2.a
> > C:\msys\1.0\mingw32\include\pthread.h
> > C:\msys\1.0\mingw32\lib\libpthread.a
> > TODO(fbarchard): build with O2
> 
> These instructions should be a part of the MinGW setup.  Frank, you'll have to
> build + package up pthreads in a way that can be extracted into an msys
> installation so that windows users can build using the proper build of
pthreads.

There's another CL out that has these instructions merged in.  Can you comment
on that one instead?

http://codereview.chromium.org/164120/diff/16/1010#newcode37
Line 37: patch -p1 < ../static_pthread_O2.patch
On 2009/08/07 21:48:34, fbarchard wrote:
> Sorry I forgot theres also a code patch.
> These are the original instructions
> http://ffmpeg.arrozcru.org/wiki/images/d/dd/Ffmpeg_r15966_static_pthreads.diff
> We need the change in libavcodec/allcodecs.c
> 

Code patch added.