Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Issue 16412: Experimental: push the new code generator infrastructure into the... (Closed)

Created:
12 years ago by Kevin Millikin (Chromium)
Modified:
3 years, 10 months ago
Reviewers:
iposva, William Hesse
CC:
v8-dev
Visibility:
Public.

Description

Experimental: push the new code generator infrastructure into the count operations (pre- and post- increment and decrement). For frame-allocated slots in registers, we can overwrite them. This is a simple way to reduce register pressure by not consuming a register to back the frame element that will be written before being read again. It also ensures that frame-allocated slots that are the target of count operations do not migrate to a different register, which would make merging generate silly moves. This change allows INVALID frame elements to appear in expected frames. It is always safe to merge to invalid elements. Currently we require both source and target elements to be invalid, but that could be relaxed. Committed: http://code.google.com/p/v8/source/detail?r=1017

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+177 lines, -32 lines) Patch
M src/codegen-ia32.h View 1 chunk +5 lines, -0 lines 0 comments Download
M src/codegen-ia32.cc View 4 chunks +68 lines, -22 lines 0 comments Download
M src/jump-target.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/jump-target-ia32.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M src/virtual-frame-ia32.h View 7 chunks +30 lines, -0 lines 0 comments Download
M src/virtual-frame-ia32.cc View 9 chunks +64 lines, -10 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Kevin Millikin (Chromium)
12 years ago (2008-12-22 15:04:51 UTC) #1
William Hesse
12 years ago (2008-12-22 15:33:07 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698