mojo/public/tools/bindings/generators/mojom_cpp_generator.py - Issue 1641163005: [Draft] try out the idea of adding export macros for C++ bindings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/tools/bindings/generators/mojom_cpp_generator.py

Issue 1641163005: [Draft] try out the idea of adding export macros for C++ bindings. Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « mojo/public/tools/bindings/generators/cpp_templates/wrapper_union_class_declaration.tmpl ('k') | mojo/public/tools/bindings/mojom.gni » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/public/tools/bindings/generators/mojom_cpp_generator.py

diff --git a/mojo/public/tools/bindings/generators/mojom_cpp_generator.py b/mojo/public/tools/bindings/generators/mojom_cpp_generator.py

index e3288679a735b443bfb7e11132a801331281b264..eb491ab831ce2c1331e8bef1040a4e157e5fe3cf 100644

--- a/mojo/public/tools/bindings/generators/mojom_cpp_generator.py

+++ b/mojo/public/tools/bindings/generators/mojom_cpp_generator.py

@@ -475,6 +475,8 @@ class Generator(generator.Generator):

extra_headers = set()

for name, entry in self.typemap.iteritems():

extra_headers.update(entry["headers"])

+ if self.dll_export_include:

+ extra_headers.add(self.dll_export_include)

return list(extra_headers)

def GetJinjaExports(self):

@@ -490,6 +492,7 @@ class Generator(generator.Generator):

"interfaces": self.GetInterfaces(),

"variant": self.variant,

"extra_headers": self.GetExtraHeaders(),

+ "dll_export": self.dll_export_declaration,

}

@staticmethod