mojo/public/tools/bindings/generators/cpp_templates/wrapper_class_declaration.tmpl - Issue 1641163005: [Draft] try out the idea of adding export macros for C++ bindings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/tools/bindings/generators/cpp_templates/wrapper_class_declaration.tmpl

Issue 1641163005: [Draft] try out the idea of adding export macros for C++ bindings. Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « mojo/public/interfaces/bindings/tests/BUILD.gn ('k') | mojo/public/tools/bindings/generators/cpp_templates/wrapper_union_class_declaration.tmpl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/public/tools/bindings/generators/cpp_templates/wrapper_class_declaration.tmpl

diff --git a/mojo/public/tools/bindings/generators/cpp_templates/wrapper_class_declaration.tmpl b/mojo/public/tools/bindings/generators/cpp_templates/wrapper_class_declaration.tmpl

index d0b9fd9cfe972cacbefc80b8cc4c46e838b1a9f4..1eef218a366ff93fea9f10a3498d36d9cbdc5db8 100644

--- a/mojo/public/tools/bindings/generators/cpp_templates/wrapper_class_declaration.tmpl

+++ b/mojo/public/tools/bindings/generators/cpp_templates/wrapper_class_declaration.tmpl

@@ -2,7 +2,7 @@

class {{struct.name}}_Reader;

-class {{struct.name}} {

+class {{dll_export}} {{struct.name}} {

public:

using Data_ = internal::{{struct.name}}_Data;

using Reader = {{struct.name}}_Reader;