Preparation CL for H264 support in WebRTC.

content/content.gyp

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 {
   'variables': {
     'chromium_code': 1,  # Use higher warning level.
     'chromium_enable_vtune_jit_for_v8%': 0,  # enable the vtune support for V8 engine.
     'directxsdk_exists': '<!pymod_do_main(dir_exists ../third_party/directxsdk)',
   },
   'target_defaults': {
     'defines': ['CONTENT_IMPLEMENTATION'],
     'conditions': [
       # TODO(jschuh): Remove this after crbug.com/173851 gets fixed.
       ['OS=="win" and target_arch=="x64"', {
         'msvs_settings': {
           'VCCLCompilerTool': {
             'AdditionalOptions': ['/bigobj'],
           },
         },
       }],
     ],
   },
+  'targets': [
+    {
+      # GN version: //content/renderer:renderer_features
+      'target_name': 'renderer_features',
+      'includes': [
+        '../build/buildflag_header.gypi',
+        '../third_party/webrtc/build/common.gypi',
+      ],
+      'conditions': [
+        # This conditional looks insane, but without it |rtc_use_h264| is not

[brettw, 2016/02/03 22:19:55]

I don't really care about this too much, but I *think* the right solution is to
replace the outer conditions with another variables block:
  'variables': {
     'variables': {
        'buildflag_hea...<other stuff>
      }
   }
Can you see if that fixes the problem before checking in?

[hbos_chromium, 2016/02/04 10:47:32]

I tried that (including 'var': '<(var)' in the outer 'variables'), but it didn't
work. Undefined variable rtc_use_h264. GYP is horrendous isn't it. Keeping it
this way.

+        # recognized as defined. Might have something to do with scopes. Moving
+        # the inclusion of third_party/webrtc/build/common.gypi to outside of
+        # 'targets' is not an option, then we get compile errors.
+        ['1==1', {
+          'variables': {
+            'buildflag_header_path': 'content/renderer/renderer_features.h',
+            'buildflag_flags': [
+              'RTC_USE_H264=<(rtc_use_h264)',
+            ],
+          },
+        }],
+      ],
+    },
+  ],
   'conditions': [
     ['OS != "ios"', {
       'includes': [
         '../build/win_precompile.gypi',
         'content_resources.gypi',
       ],
     }],
     ['OS == "win"', {
       'targets': [
         {
@@ skipping 221 matching lines @@
               'target_name': 'content_renderer',
               'type': 'static_library',
               'variables': { 'enable_wexit_time_destructors': 1, },
               'includes': [
                 'content_renderer.gypi',
               ],
               'dependencies': [
                 'content_child',
                 'content_common',
                 'content_resources',
+                'renderer_features',
               ],
               'export_dependent_settings': [
                 'content_common',
               ],
               'conditions': [
                 ['chromium_enable_vtune_jit_for_v8==1', {
                   'dependencies': [
                     '../v8/src/third_party/vtune/v8vtune.gyp:v8_vtune',
                   ],
                 }],
@@ skipping 19 matching lines @@
     },
     {  # component != static_library
       'targets': [
         {
           # GN version: //content
           'target_name': 'content',
           'type': 'shared_library',
           'variables': { 'enable_wexit_time_destructors': 1, },
           'dependencies': [
             'content_resources',
+            'renderer_features',
           ],
           'conditions': [
             ['chromium_enable_vtune_jit_for_v8==1', {
               'dependencies': [
                 '../v8/src/third_party/vtune/v8vtune.gyp:v8_vtune',
               ],
             }],
           ],
           'includes': [
             'content_app.gypi',
@@ skipping 334 matching lines @@
           },
           'includes': [
             '../build/android/copy_ex.gypi',
             '../build/android/v8_external_startup_data_arch_suffix.gypi',
           ],
         },
       ],
     }],  # OS == "android"
   ],
 }