src/compiler/code-generator.cc - Issue 1641153003: [wasm] Initialize the root register for WASM tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/code-generator.cc

Issue 1641153003: [wasm] Initialize the root register for WASM tests. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@stackslot_cl

Patch Set: Root register is now initialized at the right place, and only in the test wrapper. Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: src/compiler/code-generator.cc

diff --git a/src/compiler/code-generator.cc b/src/compiler/code-generator.cc

index 313567ed87fe6e2fe095b841aec63d0620ede5a7..68d4cc38575eb9438d6ee354f756276b6878f23f 100644

--- a/src/compiler/code-generator.cc

+++ b/src/compiler/code-generator.cc

@@ -78,10 +78,12 @@ Handle<Code> CodeGenerator::GenerateCode() {

if (linkage()->GetIncomingDescriptor()->IsJSFunctionCall()) {

ProfileEntryHookStub::MaybeCallEntryHook(masm());

}

// Architecture-specific, linkage-specific prologue.

info->set_prologue_offset(masm()->pc_offset());

AssemblePrologue();

+ if (linkage()->GetIncomingDescriptor()->InitializeRootRegister()) {

+ masm()->InitializeRootRegister();

+ }

// Define deoptimization literals for all inlined functions.

DCHECK_EQ(0u, deoptimization_literals_.size());