Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(489)

Issue 1641153003: [wasm] Initialize the root register for WASM tests. (Closed)

Created:
4 years, 10 months ago by ahaas
Modified:
4 years, 10 months ago
Reviewers:
titzer
CC:
v8-reviews_googlegroups.com, v8-x87-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@stackslot_cl
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Initialize the root register for WASM tests. The root register is needed (at least on x64) to access ExternalReferences. R=titzer@chromium.org Committed: https://crrev.com/a17bd3f3bc5855a7dcc010792e060b8e3a68965d Cr-Commit-Position: refs/heads/master@{#33631}

Patch Set 1 #

Patch Set 2 : Root register is now initialized at the right place, and only in the test wrapper. #

Total comments: 1

Patch Set 3 : Removed the stray blank. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -6 lines) Patch
M src/compiler/c-linkage.cc View 1 2 chunks +4 lines, -2 lines 0 comments Download
M src/compiler/code-generator.cc View 1 1 chunk +3 lines, -1 line 0 comments Download
M src/compiler/linkage.h View 1 3 chunks +8 lines, -2 lines 0 comments Download
M src/ia32/macro-assembler-ia32.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M src/x87/macro-assembler-x87.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M test/cctest/compiler/codegen-tester.h View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
ahaas
4 years, 10 months ago (2016-01-28 17:00:46 UTC) #1
titzer
lgtm https://codereview.chromium.org/1641153003/diff/20001/src/compiler/wasm-linkage.cc File src/compiler/wasm-linkage.cc (right): https://codereview.chromium.org/1641153003/diff/20001/src/compiler/wasm-linkage.cc#newcode267 src/compiler/wasm-linkage.cc:267: Stray blank line.
4 years, 10 months ago (2016-02-01 08:24:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1641153003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1641153003/40001
4 years, 10 months ago (2016-02-01 08:42:54 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 10 months ago (2016-02-01 09:17:04 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-01 09:17:26 UTC) #8
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/a17bd3f3bc5855a7dcc010792e060b8e3a68965d
Cr-Commit-Position: refs/heads/master@{#33631}

Powered by Google App Engine
This is Rietveld 408576698