Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Issue 1641143002: [Interpreter] Adds a placeholder merge node when visiting jumps. (Closed)

Created:
4 years, 10 months ago by mythria
Modified:
4 years, 10 months ago
Reviewers:
oth, Michael Starzinger
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Interpreter] Adds a placeholder merge node when visiting jumps. This is to fix a bug in the bytecode graph builder. This cl adds a new merge node before we copy the environment on conditional/unconditional jumps. Since these environments could be merged later, we add a place holder merge so that the control dependencies are correctly merged. If we do not have a merge node we may incorrectly merge the dependencies into the previous block. For ex: test-run-variables/ContextStoreVariables in cctests. BUG=v8:4280 LOG=N Committed: https://crrev.com/d0e01b0ba0f58fb1d94b21e8dcb33bb95917b1f0 Cr-Commit-Position: refs/heads/master@{#33591}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -0 lines) Patch
M src/compiler/bytecode-graph-builder.cc View 1 1 chunk +6 lines, -0 lines 0 comments Download
M test/cctest/compiler/test-run-bytecode-graph-builder.cc View 2 chunks +77 lines, -0 lines 0 comments Download

Messages

Total messages: 23 (10 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1641143002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1641143002/1
4 years, 10 months ago (2016-01-28 11:35:17 UTC) #2
commit-bot: I haz the power
Dry run: No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even ...
4 years, 10 months ago (2016-01-28 11:35:18 UTC) #4
mythria
PTAL Thanks, Mythri
4 years, 10 months ago (2016-01-28 11:36:55 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1641143002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1641143002/1
4 years, 10 months ago (2016-01-28 11:40:18 UTC) #8
oth
lgtm, thank you. Nice tests.
4 years, 10 months ago (2016-01-28 12:01:14 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-01-28 12:01:43 UTC) #11
Michael Starzinger
LGTM. I am fine with landing this as it is. And especially the tests are ...
4 years, 10 months ago (2016-01-28 12:27:50 UTC) #12
mythria
Thanks for your reviews. https://codereview.chromium.org/1641143002/diff/1/src/compiler/bytecode-graph-builder.cc File src/compiler/bytecode-graph-builder.cc (right): https://codereview.chromium.org/1641143002/diff/1/src/compiler/bytecode-graph-builder.cc#newcode1904 src/compiler/bytecode-graph-builder.cc:1904: NewMerge(); On 2016/01/28 12:27:50, Michael ...
4 years, 10 months ago (2016-01-28 13:03:16 UTC) #13
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1641143002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1641143002/20001
4 years, 10 months ago (2016-01-28 13:04:03 UTC) #15
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-01-28 13:25:55 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1641143002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1641143002/20001
4 years, 10 months ago (2016-01-28 16:19:47 UTC) #20
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-01-28 16:21:30 UTC) #21
commit-bot: I haz the power
4 years, 10 months ago (2016-01-28 16:22:07 UTC) #23
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d0e01b0ba0f58fb1d94b21e8dcb33bb95917b1f0
Cr-Commit-Position: refs/heads/master@{#33591}

Powered by Google App Engine
This is Rietveld 408576698