Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1054)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1641133004: Document the getSourceReport rpc in service.md. Bump version to 3.1. (Closed)

Created:
4 years, 10 months ago by turnidge
Modified:
4 years, 10 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, rmacnak, Cutch, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Document the getSourceReport rpc in service.md. Bump version to 3.1. BUG= R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/bf385e448c30323d68524df99f7329174f70ceef

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+146 lines, -4 lines) Patch
M runtime/observatory/tests/service/get_version_rpc_test.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/service.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/service/service.md View 1 6 chunks +144 lines, -2 lines 1 comment Download

Messages

Total messages: 5 (2 generated)
turnidge
4 years, 10 months ago (2016-01-28 20:47:30 UTC) #2
rmacnak
lgtm https://codereview.chromium.org/1641133004/diff/40001/runtime/vm/service/service.md File runtime/vm/service/service.md (right): https://codereview.chromium.org/1641133004/diff/40001/runtime/vm/service/service.md#newcode615 runtime/vm/service/service.md:615: have semantic side effects on the running Dart ...
4 years, 10 months ago (2016-01-28 21:45:09 UTC) #3
turnidge
4 years, 10 months ago (2016-01-29 18:40:23 UTC) #5
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
bf385e448c30323d68524df99f7329174f70ceef (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698