Issue 164113003: [Android] Use fast ELF symbolizer for symbols.py and tombstones.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 164113003: [Android] Use fast ELF symbolizer for symbols.py and tombstones. (Closed)

Created:
6 years, 10 months ago by Primiano Tucci (use gerrit)

Modified:
4 years, 10 months ago

Reviewers:
bulach

CC:
chromium-reviews, Philippe

Base URL:
https://chromium.googlesource.com/chromium/src.git@mi_sym

Visibility:
Public.

More Reviews

Description

[Android] Use fast ELF symbolizer for symbols.py and tombstones. crrev.com/167893009 has introduced a faster ELF symbolizer. Switching symbols.py to use that one. BUG=

Patch Set 1 : #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -28 lines)			Patch
	M	third_party/android_platform/development/scripts/symbol.py	View		3 chunks	+24 lines, -28 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Primiano Tucci (use gerrit)

bulach@: I tried this on top of crrev.com/167893009 with some tombstones I generated on the ...

6 years, 10 months ago (2014-02-24 12:34:53 UTC) #1

bulach

6 years, 10 months ago (2014-02-24 13:47:25 UTC) #2

lgtm, thanks!

please, make sure you update the "Local Modifications" entry in this file as
well:
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/androi...

as more juicy tombstones: sprinkle "CHECK(false);" liberally in your local repo,
that should give you as many stack traces as you may need.. ;)

there's also:
https://code.google.com/p/chromium/codesearch#chromium/src/build/android/symb...

afaict, it exercises (indirectly) this code here..
I think it should cover enough cases, but feel free to add more if you want..

Expand Messages | Collapse Messages