Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1193)

Issue 1641113002: Revert of Remove references between RTCPeerConnection and RTCDataChannel. (Closed)

Created:
4 years, 10 months ago by Guido Urdaneta
Modified:
4 years, 10 months ago
CC:
chromium-reviews, blink-reviews, tommyw+watchlist_chromium.org, Taylor_Brandstetter, perkj_chrome, hta - Chromium
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Remove references between RTCPeerConnection and RTCDataChannel. (patchset #3 id:40001 of https://codereview.chromium.org/1634073003/ ) Reason for revert: It turns out that the underlying WebRTC DataChannel objects does not maintain a reference to the WebRTC PeerConnection, so we do need to keep the reference in the blink layer. PS2 was the correct patch. Original issue's description: > The underlying WebRTC objects maintain all the needed references. > No references are actually needed in the blink layer. > > BUG=564965 > > Committed: https://crrev.com/0004ce15cdf065966508c61a5265ae8662e363ed > Cr-Commit-Position: refs/heads/master@{#371667} TBR=tommi@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=564965 Committed: https://crrev.com/c269afa267e702e823807b60ede5cdd44abdb4fa Cr-Commit-Position: refs/heads/master@{#372072}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -19 lines) Patch
M third_party/WebKit/Source/modules/mediastream/RTCDataChannel.h View 5 chunks +11 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/mediastream/RTCDataChannel.cpp View 8 chunks +49 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/modules/mediastream/RTCDataChannelTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/mediastream/RTCPeerConnection.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/mediastream/RTCPeerConnection.cpp View 4 chunks +11 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Guido Urdaneta
Created Revert of Remove references between RTCPeerConnection and RTCDataChannel.
4 years, 10 months ago (2016-01-28 10:19:45 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1641113002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1641113002/1
4 years, 10 months ago (2016-01-28 10:20:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1641113002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1641113002/1
4 years, 10 months ago (2016-01-28 10:32:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1641113002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1641113002/1
4 years, 10 months ago (2016-01-28 11:02:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1641113002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1641113002/1
4 years, 10 months ago (2016-01-28 11:32:48 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-01-28 11:37:48 UTC) #7
commit-bot: I haz the power
4 years, 10 months ago (2016-01-28 11:38:56 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c269afa267e702e823807b60ede5cdd44abdb4fa
Cr-Commit-Position: refs/heads/master@{#372072}

Powered by Google App Engine
This is Rietveld 408576698