Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1641103003:
arc: Add owners to chrome/browser/chromeos/arc (Closed)
Descriptionarc: Add owners to chrome/browser/chromeos/arc
We need owners for ARC components that would improve
review load balance.
BUG=N/A
Committed: https://crrev.com/1b5ebb9b122c6913074fc30a6ca0e32ef7261af3
Cr-Commit-Position: refs/heads/master@{#372287}
Patch Set 1 #Patch Set 2 : suggested more owners #
Total comments: 2
Patch Set 3 : updated #Messages
Total messages: 21 (8 generated)
Description was changed from ========== arc: Add owners to chrome/browser/chromeos/arc We need owners for ARC components that would improve review load balance. BUG=N/A ========== to ========== arc: Add owners to chrome/browser/chromeos/arc We need owners for ARC components that would improve review load balance. BUG=N/A ==========
khmel@chromium.org changed reviewers: + elijahtaylor@chromium.org, satorux@chromium.org
Hi, Please let me know if you think someone else would be good as a OWNER. PTAL
On 2016/01/28 17:10:53, khmel wrote: > Hi, > > Please let me know if you think someone else would be good as a OWNER. > > PTAL prefer to add hidehiko@chromium.org and lhchavez@chromium.org too, as long as they also agree
khmel@chromium.org changed reviewers: + hidehiko@chromium.org, lhchavez@chromium.org
Added more owners. PTAL
lgtm
lgtm
elijahtaylor@chromium.org changed reviewers: + yusukes@chromium.org
https://codereview.chromium.org/1641103003/diff/20001/chrome/browser/chromeos... File chrome/browser/chromeos/arc/OWNERS (left): https://codereview.chromium.org/1641103003/diff/20001/chrome/browser/chromeos... chrome/browser/chromeos/arc/OWNERS:1: elijahtaylor@chromium.org actually, can you swap me out for yusukes@chromium.org so we can better load balance reviews?
https://codereview.chromium.org/1641103003/diff/20001/chrome/browser/chromeos... File chrome/browser/chromeos/arc/OWNERS (left): https://codereview.chromium.org/1641103003/diff/20001/chrome/browser/chromeos... chrome/browser/chromeos/arc/OWNERS:1: elijahtaylor@chromium.org On 2016/01/28 19:25:02, elijahtaylor1 wrote: > actually, can you swap me out for mailto:yusukes@chromium.org so we can better load > balance reviews? Done.
lgtm
lgtm
lgtm
The CQ bit was checked by satorux@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from elijahtaylor@chromium.org, lhchavez@chromium.org Link to the patchset: https://codereview.chromium.org/1641103003/#ps40001 (title: "updated")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1641103003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1641103003/40001
Message was sent while issue was closed.
Description was changed from ========== arc: Add owners to chrome/browser/chromeos/arc We need owners for ARC components that would improve review load balance. BUG=N/A ========== to ========== arc: Add owners to chrome/browser/chromeos/arc We need owners for ARC components that would improve review load balance. BUG=N/A ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== arc: Add owners to chrome/browser/chromeos/arc We need owners for ARC components that would improve review load balance. BUG=N/A ========== to ========== arc: Add owners to chrome/browser/chromeos/arc We need owners for ARC components that would improve review load balance. BUG=N/A Committed: https://crrev.com/1b5ebb9b122c6913074fc30a6ca0e32ef7261af3 Cr-Commit-Position: refs/heads/master@{#372287} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/1b5ebb9b122c6913074fc30a6ca0e32ef7261af3 Cr-Commit-Position: refs/heads/master@{#372287} |
