Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issue 1641073003: dart2js CPS: Remove an invalid assertion in shrinking reductions. (Closed)

Created:
4 years, 10 months ago by Kevin Millikin (Google)
Modified:
4 years, 10 months ago
Reviewers:
asgerf
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

dart2js CPS: Remove an invalid assertion in shrinking reductions. Because we search for new redexes while performing reductions, we can't always assert that a term is well-formed. In this case, it's not true that all invocations of a continuation will have the same number of arguments while we are in the middle of performing a dead parameter reduction. BUG= R=asgerf@google.com Committed: https://github.com/dart-lang/sdk/commit/b76ffa9505f1a282cb5c83a1d769925c2aa3c3c2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M pkg/compiler/lib/src/cps_ir/shrinking_reductions.dart View 1 chunk +7 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Kevin Millikin (Google)
4 years, 10 months ago (2016-01-28 11:49:46 UTC) #2
asgerf
lgtm
4 years, 10 months ago (2016-01-28 11:54:42 UTC) #3
Kevin Millikin (Google)
4 years, 10 months ago (2016-01-28 11:56:14 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b76ffa9505f1a282cb5c83a1d769925c2aa3c3c2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698