Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1641063002: DevTools: InspectorTest.TestFileSystem to support Entry.remove (Closed)

Created:
4 years, 11 months ago by lushnikov
Modified:
4 years, 11 months ago
Reviewers:
pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: InspectorTest.TestFileSystem to support Entry.remove Improve InspectorTest.TestFileSystem to support Entry.remove method. BUG=None R=pfeldman Committed: https://crrev.com/bb2a2abb3b6bc825e7fb1163c93b785f2ecd5696 Cr-Commit-Position: refs/heads/master@{#371979}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -4 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/inspector/isolated-filesystem-test.js View 4 chunks +26 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
lushnikov
ptal
4 years, 11 months ago (2016-01-28 01:26:33 UTC) #1
pfeldman
lgtm
4 years, 11 months ago (2016-01-28 01:27:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1641063002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1641063002/1
4 years, 11 months ago (2016-01-28 02:14:46 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-28 03:07:16 UTC) #5
commit-bot: I haz the power
4 years, 11 months ago (2016-01-28 03:08:13 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/bb2a2abb3b6bc825e7fb1163c93b785f2ecd5696
Cr-Commit-Position: refs/heads/master@{#371979}

Powered by Google App Engine
This is Rietveld 408576698