Docserver manifest follow up (rewrite)

chrome/common/extensions/docs/server2/features_utility.py

Index: chrome/common/extensions/docs/server2/features_utility.py
diff --git a/chrome/common/extensions/docs/server2/features_utility.py b/chrome/common/extensions/docs/server2/features_utility.py
new file mode 100644
index 0000000000000000000000000000000000000000..8af0b7ba1ce08c7a47caaa910b35de49ef6c0faf
--- /dev/null
+++ b/chrome/common/extensions/docs/server2/features_utility.py
@@ -0,0 +1,47 @@
+# Copyright 2013 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+def ProcessFeaturesFile(features_json):
+  '''Standardize a features file dictionary by ignoring whitelisted entries,
+  thus also reducing keys with lists as values into simple dictionaries.
+  Returns the standardized dictionary.
+  '''
+  master_dict = {}
+
+  for name, value in features_json.iteritems():
+    if isinstance(value, list):
+      temp = None
+      for subvalue in value:
+        if not 'whitelist' in subvalue:
+          temp = subvalue
+          break
+      else:
+        # Ignore this entry in the features file.
+        continue
+      value = temp
+
+    if 'whitelist' in value:
+      continue
+    master_dict[name] = { 'platform': [] }
+
+    platforms = value.pop('extension_types')
+    if platforms == 'all' or 'extension' in platforms:
+      master_dict[name]['platform'].append('extension')
+    if platforms == 'all' or 'platform_app' in platforms:
+      master_dict[name]['platform'].append('app')
+
+    master_dict[name]['name'] = name
+    master_dict[name].update(value)
+
+  return master_dict
+
+def MergeDictionaries(dest, addition):
+  '''Do an in place dictionary merge and combine sub dictionaries with a
+  standard merge.
+  '''
+  for key, value in addition.iteritems():
+    if key in dest:
+      dest[key].update(value)
+    else:
+      dest[key] = value

[not at google - send to devlin, 2013/07/24 21:45:56]

I would rather there were all OO. Create an abstraction for a feature file (call
it... FeatureFile) and query that for typed data, rather than transforming
arbitrary JSON to some other arbitrary JSON format.

You would have properties like extension_types and methods like Merge (how is
this different to dict.update() again?)

Note that I may actually want to move something like this into
json_schema_compiler proper in order to implement feature file compilation - but
don't worry about that yet. Just keep in mind that... I'll be keeping that in
mind.

[jshumway, 2013/07/26 00:36:46]

Did my best to 'OOify' it.
The difference is that merge (now named MergeWith) merges sub dictionaries as
well, instead of blindly replacing keys. In code...

{'x': {'y': 1}}.update({'x': {'z': 2}}) -> {'x': {'z': 2}}

{'x': {'y': 1}}.MergeWith({'x': {'z': 2}}) -> {'x': {'y': 1, 'z': 2}}