Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 1640973002: git_test_utils: Automatic commit dates are now in UTC. (Closed)

Created:
4 years, 10 months ago by Matt Giuca
Modified:
4 years, 10 months ago
Reviewers:
iannucci
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

git_test_utils: Automatic commit dates are now in UTC. This fixes the test being dependent on the system time, and undefined behaviour resulting from negative timestamps in positive-offset timezones. BUG=581895 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=298438

Patch Set 1 #

Messages

Total messages: 7 (3 generated)
Matt Giuca
Note: I didn't find any testing module for git_test_utils (and I think this should be ...
4 years, 10 months ago (2016-01-27 23:34:32 UTC) #2
iannucci
lgtm c) I think this is fine :)
4 years, 10 months ago (2016-01-28 00:58:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1640973002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1640973002/1
4 years, 10 months ago (2016-01-28 07:55:33 UTC) #5
commit-bot: I haz the power
4 years, 10 months ago (2016-01-28 07:57:35 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=298438

Powered by Google App Engine
This is Rietveld 408576698