Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1640933004:
SkPngFilters: guard with libpng >= 1.5.7 (Closed)
DescriptionSkPngFilters: guard with libpng >= 1.5.7
The read_filter array was added in libpng-1.5.7.
No point to these filter methods if we can't plug them into libpng.
TBR=msarett@google.com
NOTRY=true
NOPRESUBMIT=true
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1640933004
Committed: https://skia.googlesource.com/skia/+/62358e77c2b8f31c59db0a0179bfed8feaa41929
Patch Set 1 #Patch Set 2 : we dont know that here #Patch Set 3 : fine #Patch Set 4 : note #Messages
Total messages: 36 (20 generated)
Description was changed from ========== SkPngFilters: guard with libpng >= 1.5.7 The read_filter array was added in libpng-1.5.7. No point to these filter methods if we can't plug them into libpng. BUG=skia: ========== to ========== SkPngFilters: guard with libpng >= 1.5.7 The read_filter array was added in libpng-1.5.7. No point to these filter methods if we can't plug them into libpng. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
The CQ bit was checked by mtklein@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1640933004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1640933004/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...) Build-Ubuntu-GCC-Arm64-Debug-Android-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm...)
Description was changed from ========== SkPngFilters: guard with libpng >= 1.5.7 The read_filter array was added in libpng-1.5.7. No point to these filter methods if we can't plug them into libpng. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== SkPngFilters: guard with libpng >= 1.5.7 The read_filter array was added in libpng-1.5.7. No point to these filter methods if we can't plug them into libpng. TBR=msarett@google.com BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
The CQ bit was checked by mtklein@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1640933004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1640933004/60001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: Build-Ubuntu-GCC-Arm64-Debug-Android-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm...)
The CQ bit was checked by mtklein@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1640933004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1640933004/60001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)
The CQ bit was checked by mtklein@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1640933004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1640933004/60001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED, http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/bu...)
The CQ bit was checked by mtklein@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1640933004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1640933004/60001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED, http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/bu...)
The CQ bit was checked by mtklein@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1640933004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1640933004/60001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED, http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/bu...)
Description was changed from ========== SkPngFilters: guard with libpng >= 1.5.7 The read_filter array was added in libpng-1.5.7. No point to these filter methods if we can't plug them into libpng. TBR=msarett@google.com BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== SkPngFilters: guard with libpng >= 1.5.7 The read_filter array was added in libpng-1.5.7. No point to these filter methods if we can't plug them into libpng. TBR=msarett@google.com NOTRY=true BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
The CQ bit was checked by mtklein@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1640933004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1640933004/60001
Description was changed from ========== SkPngFilters: guard with libpng >= 1.5.7 The read_filter array was added in libpng-1.5.7. No point to these filter methods if we can't plug them into libpng. TBR=msarett@google.com NOTRY=true BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== SkPngFilters: guard with libpng >= 1.5.7 The read_filter array was added in libpng-1.5.7. No point to these filter methods if we can't plug them into libpng. TBR=msarett@google.com NOTRY=true NOPRESUBMIT=true BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED, http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/bu...)
The CQ bit was checked by mtklein@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1640933004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1640933004/60001
Message was sent while issue was closed.
Description was changed from ========== SkPngFilters: guard with libpng >= 1.5.7 The read_filter array was added in libpng-1.5.7. No point to these filter methods if we can't plug them into libpng. TBR=msarett@google.com NOTRY=true NOPRESUBMIT=true BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== SkPngFilters: guard with libpng >= 1.5.7 The read_filter array was added in libpng-1.5.7. No point to these filter methods if we can't plug them into libpng. TBR=msarett@google.com NOTRY=true NOPRESUBMIT=true BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... Committed: https://skia.googlesource.com/skia/+/62358e77c2b8f31c59db0a0179bfed8feaa41929 ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as https://skia.googlesource.com/skia/+/62358e77c2b8f31c59db0a0179bfed8feaa41929 |
