Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 1640933003: Dart: Roll runtime forward (Closed)

Created:
4 years, 11 months ago by zra
Modified:
4 years, 11 months ago
Reviewers:
Cutch
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Dart: Roll runtime forward This roll will have a negative impact on startup performance due to the need to eagerly compute a Uri for the script. See the comment in builtin.dart. Also, CreateIsolateCallback is now always passed a script_uri, even for an Isolate.spawn, so that code is re-jiggered a bit as well. R=johnmccutchan@google.com Committed: https://chromium.googlesource.com/external/mojo/+/68d50d71c802b3f56aa535d9403e20804b11ef52

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -21 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M mojo/dart/embedder/builtin.dart View 2 chunks +17 lines, -1 line 0 comments Download
M mojo/dart/embedder/dart_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/dart/embedder/dart_controller.cc View 6 chunks +32 lines, -18 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
zra
4 years, 11 months ago (2016-01-27 23:09:15 UTC) #2
Cutch
lgtm
4 years, 11 months ago (2016-01-27 23:18:43 UTC) #3
zra
4 years, 11 months ago (2016-01-27 23:19:38 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
68d50d71c802b3f56aa535d9403e20804b11ef52 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698