Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 1640913002: Revert of Move SelectionAdjust to its own file (Closed)

Created:
4 years, 11 months ago by lushnikov
Modified:
4 years, 11 months ago
Reviewers:
tkent, yosin_UTC9
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Move SelectionAdjust to its own file (patchset #2 id:20001 of https://codereview.chromium.org/1640623002/ ) Reason for revert: This refactoring breaks text selection in DevTools console. Please see http://crbug.com/581800 for details Original issue's description: > Move SelectionAdjuster to its own file > > This patch moves implementations of |SelectionAdjuster| into its own file. > > This is a follow-up patch of http://crrev.com/1630903005, which introduces > |SelectionAdjuster| into "SelectionEditor.cpp" and "VisibleSelection.cpp". > > BUG=n/a > TEST=n/a; no behavior changes > > Committed: https://crrev.com/da8f47a0153b025331e2c8ed62c4f6510c63c703 > Cr-Commit-Position: refs/heads/master@{#371751} TBR=tkent@chromium.org,yosin@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=n/a Committed: https://crrev.com/39d0fed9c6301bb378c26c913a579bb738b221c9 Cr-Commit-Position: refs/heads/master@{#371854}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+259 lines, -304 lines) Patch
M third_party/WebKit/Source/core/core.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
D third_party/WebKit/Source/core/editing/SelectionAdjuster.h View 1 chunk +0 lines, -27 lines 0 comments Download
D third_party/WebKit/Source/core/editing/SelectionAdjuster.cpp View 1 chunk +0 lines, -273 lines 0 comments Download
M third_party/WebKit/Source/core/editing/SelectionEditor.cpp View 2 chunks +77 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/VisibleSelection.h View 1 chunk +10 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/VisibleSelection.cpp View 3 chunks +172 lines, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
lushnikov
Created Revert of Move SelectionAdjust to its own file
4 years, 11 months ago (2016-01-27 20:13:35 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1640913002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1640913002/1
4 years, 11 months ago (2016-01-27 20:15:54 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-27 20:18:23 UTC) #3
commit-bot: I haz the power
4 years, 11 months ago (2016-01-27 20:19:34 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/39d0fed9c6301bb378c26c913a579bb738b221c9
Cr-Commit-Position: refs/heads/master@{#371854}

Powered by Google App Engine
This is Rietveld 408576698