Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 1640883003: tools/battor_agent: *Actually* makes the BattOr build on all platforms (Closed)

Created:
4 years, 10 months ago by charliea (OOO until 10-5)
Modified:
4 years, 10 months ago
Reviewers:
Dirk Pranke, dpranke
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

tools/battor_agent: *Actually* makes the BattOr build on all platforms I thought this was happening before, but upon further inspection, it looks like whatever I did wasn't working. This way of building the battor_agent seems to be. Given that the battor_agent will be used by Telemetry, it makes sense to build this on the waterfall. BUG=571458 Committed: https://crrev.com/faf17b484d69f409b1e2cb8237ac79069434b8b4 Cr-Commit-Position: refs/heads/master@{#372213}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -10 lines) Patch
M build/all.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M testing/buildbot/chromium.mac.json View 2 chunks +1 line, -5 lines 0 comments Download
M testing/buildbot/chromium.win.json View 4 chunks +3 lines, -5 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1640883003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1640883003/1
4 years, 10 months ago (2016-01-28 16:50:58 UTC) #2
charliea (OOO until 10-5)
4 years, 10 months ago (2016-01-28 18:13:42 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-01-28 19:14:43 UTC) #6
Dirk Pranke
lgtm
4 years, 10 months ago (2016-01-28 23:18:27 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1640883003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1640883003/1
4 years, 10 months ago (2016-01-29 00:05:11 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-01-29 00:12:15 UTC) #11
commit-bot: I haz the power
4 years, 10 months ago (2016-01-29 00:14:00 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/faf17b484d69f409b1e2cb8237ac79069434b8b4
Cr-Commit-Position: refs/heads/master@{#372213}

Powered by Google App Engine
This is Rietveld 408576698