Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1640873003:
Add an instrumented library stub. (Closed)
DescriptionAdd an instrumented library stub.
Add an empty file with the right name under instrumented_libraries to
convince NSS not to load the system-wide uninstrumented library with
the same name. We can not build this library from source.
BUG=520257
TBR=glider@chromium.org
Committed: https://crrev.com/8067d7167b2314851e5218b72f19b99e79b93fa9
Cr-Commit-Position: refs/heads/master@{#371931}
Patch Set 1 #
Total comments: 1
Messages
Total messages: 15 (9 generated)
eugenis@chromium.org changed reviewers: + hwennborg@google.com
hans@chromium.org changed reviewers: + hans@chromium.org
https://codereview.chromium.org/1640873003/diff/1/third_party/instrumented_li... File third_party/instrumented_libraries/instrumented_libraries.gyp (right): https://codereview.chromium.org/1640873003/diff/1/third_party/instrumented_li... third_party/instrumented_libraries/instrumented_libraries.gyp:872: '<(PRODUCT_DIR)/instrumented_libraries/<(_sanitizer_type)/<(_package_name).txt', I'm not familiar with this GYP file. It's used for building instrumented libraries, not Chromium, right? Looks reasonable as far as I can tell, but I'm not sure I'm the right person to review this.
Description was changed from ========== Add an instrumented library stub. Add an empty file with the right name under instrumented_libraries to convince NSS not to load the system-wide uninstrumented library with the same name. We can not build this library from source. BUG=520257 ========== to ========== Add an instrumented library stub. Add an empty file with the right name under instrumented_libraries to convince NSS not to load the system-wide uninstrumented library with the same name. We can not build this library from source. BUG=520257 ==========
hans@chromium.org changed reviewers: - hwennborg@google.com
Description was changed from ========== Add an instrumented library stub. Add an empty file with the right name under instrumented_libraries to convince NSS not to load the system-wide uninstrumented library with the same name. We can not build this library from source. BUG=520257 ========== to ========== Add an instrumented library stub. Add an empty file with the right name under instrumented_libraries to convince NSS not to load the system-wide uninstrumented library with the same name. We can not build this library from source. BUG=520257 TBR=glider@chromium.org ==========
eugenis@chromium.org changed reviewers: + glider@chromium.org
On 2016/01/27 23:44:04, hans wrote: > https://codereview.chromium.org/1640873003/diff/1/third_party/instrumented_li... > File third_party/instrumented_libraries/instrumented_libraries.gyp (right): > > https://codereview.chromium.org/1640873003/diff/1/third_party/instrumented_li... > third_party/instrumented_libraries/instrumented_libraries.gyp:872: > '<(PRODUCT_DIR)/instrumented_libraries/<(_sanitizer_type)/<(_package_name).txt', > I'm not familiar with this GYP file. > > It's used for building instrumented libraries, not Chromium, right? > > Looks reasonable as far as I can tell, but I'm not sure I'm the right person to > review this. Yes, it's used to rebuild the instrumented libraries once in a while. I'll land it TBR and leave the review to glider@ then.
The CQ bit was checked by eugenis@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1640873003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1640873003/1
Message was sent while issue was closed.
Description was changed from ========== Add an instrumented library stub. Add an empty file with the right name under instrumented_libraries to convince NSS not to load the system-wide uninstrumented library with the same name. We can not build this library from source. BUG=520257 TBR=glider@chromium.org ========== to ========== Add an instrumented library stub. Add an empty file with the right name under instrumented_libraries to convince NSS not to load the system-wide uninstrumented library with the same name. We can not build this library from source. BUG=520257 TBR=glider@chromium.org ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Add an instrumented library stub. Add an empty file with the right name under instrumented_libraries to convince NSS not to load the system-wide uninstrumented library with the same name. We can not build this library from source. BUG=520257 TBR=glider@chromium.org ========== to ========== Add an instrumented library stub. Add an empty file with the right name under instrumented_libraries to convince NSS not to load the system-wide uninstrumented library with the same name. We can not build this library from source. BUG=520257 TBR=glider@chromium.org Committed: https://crrev.com/8067d7167b2314851e5218b72f19b99e79b93fa9 Cr-Commit-Position: refs/heads/master@{#371931} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/8067d7167b2314851e5218b72f19b99e79b93fa9 Cr-Commit-Position: refs/heads/master@{#371931} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
