instrumented_libraries: Make prebuilt_link_helper config stick (GN)

instrumented_libraries: Make prebuilt_link_helper config stick (GN).

R=eugenis@chromium.org
BUG=581762
Committed: https://crrev.com/474b4d5c70a66e1e748a0851b515d11f904d47e2
Cr-Commit-Position: refs/heads/master@{#371882}

[Oliver Chang, 2016-01-27 19:27:29]

Description was changed from

==========
instrumented_libraries: Make prebuilt_link_helper config stick.

R=eugenis@chromium.org
BUG=581762
==========

to

==========
instrumented_libraries: Make prebuilt_link_helper config stick.

R=eugenis@chromium.org
BUG=581762
==========

[Oliver Chang, 2016-01-27 19:29:27]

ptal. disclaimer: I know very little about GN.

Without this, the rpath doesn't seem to get added to the binaries. I assume it's
because "all_dependent_configs" applies the config recursively, while
"public_configs" only applies to targets that directly depend on it
(https://chromium.googlesource.com/chromium/src/tools/gn/+/master/docs/referen...)

[Oliver Chang, 2016-01-27 19:32:08]

Description was changed from

==========
instrumented_libraries: Make prebuilt_link_helper config stick.

R=eugenis@chromium.org
BUG=581762
==========

to

==========
instrumented_libraries: Make prebuilt_link_helper config stick (GN).

R=eugenis@chromium.org
BUG=581762
==========

[aarya, 2016-01-27 19:37:00]

aarya@google.com changed reviewers:
+ dpranke@chromium.org

[eugenis, 2016-01-27 19:43:19]

I know about GN very little as well, but this looks reasonable, if it adds the
missing rpath.

LGTM

[Oliver Chang, 2016-01-27 20:58:54]

The CQ bit was checked by ochang@chromium.org

[commit-bot: I haz the power, 2016-01-27 21:04:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1640863002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1640863002/1

[Oliver Chang, 2016-01-27 21:26:42]

The CQ bit was unchecked by ochang@chromium.org

[Oliver Chang, 2016-01-27 21:38:10]

The CQ bit was checked by ochang@chromium.org

[commit-bot: I haz the power, 2016-01-27 21:40:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1640863002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1640863002/1

[commit-bot: I haz the power, 2016-01-27 21:50:45]

Description was changed from

==========
instrumented_libraries: Make prebuilt_link_helper config stick (GN).

R=eugenis@chromium.org
BUG=581762
==========

to

==========
instrumented_libraries: Make prebuilt_link_helper config stick (GN).

R=eugenis@chromium.org
BUG=581762
==========

[commit-bot: I haz the power, 2016-01-27 21:50:45]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-01-27 21:51:43]

Description was changed from

==========
instrumented_libraries: Make prebuilt_link_helper config stick (GN).

R=eugenis@chromium.org
BUG=581762
==========

to

==========
instrumented_libraries: Make prebuilt_link_helper config stick (GN).

R=eugenis@chromium.org
BUG=581762

Committed: https://crrev.com/474b4d5c70a66e1e748a0851b515d11f904d47e2
Cr-Commit-Position: refs/heads/master@{#371882}
==========

[commit-bot: I haz the power, 2016-01-27 21:51:43]

Patchset 1 (id:??) landed as
https://crrev.com/474b4d5c70a66e1e748a0851b515d11f904d47e2
Cr-Commit-Position: refs/heads/master@{#371882}

[Dirk Pranke, 2016-01-28 01:18:44]

lgtm