Support 'dart.library.X' env variables in the VM.

runtime/vm/dart_api_impl.cc

Index: runtime/vm/dart_api_impl.cc
diff --git a/runtime/vm/dart_api_impl.cc b/runtime/vm/dart_api_impl.cc
index 3c4cb1789dfdcc513acd3a3f2c959f3113ffe670..c6b78b2648233269cf25bccfe6c96195a9550a54 100644
--- a/runtime/vm/dart_api_impl.cc
+++ b/runtime/vm/dart_api_impl.cc
@@ -4945,6 +4945,35 @@ DART_EXPORT void Dart_SetWeakHandleReturnValue(Dart_NativeArguments args,
 
 
 // --- Environment ---
+RawString* Api::GetEnvironmentValue(Thread* thread, const String& name) {
+  String& result = String::Handle(CallEnvironmentCallback(thread, name));
+  if (result.IsNull()) {
+    // Every 'dart:X' library introduces an environment variable

[rmacnak, 2016/02/05 00:38:46]

Presumably we want these to answer false.
  dart.library._internal
  dart.library._builtin
  dart.library._blink

[Ivan Posva, 2016/02/05 01:10:53]

That is a very good point. Any private dart: library should be hidden by
default.

[floitsch, 2016/02/08 16:49:12]

Done.

+    // 'dart.library.X' that is set to 'true'.
+    const String& prefix = Symbols::DartLibrary();

[rmacnak, 2016/02/05 00:38:46]

if (!FLAG_enable_mirrors && name == "dart.library.mirrors")
  return false;

[floitsch, 2016/02/08 16:49:13]

Done.

+    if (name.StartsWith(prefix)) {
+      const String& library_name =
+          String::Handle(String::SubString(name, prefix.Length()));
+      if (!library_name.IsNull()) {
+        const String& dart_library_name =
+            String::Handle(String::Concat(Symbols::DartScheme(), library_name));
+        const Library& library =
+            Library::Handle(Library::LookupLibrary(dart_library_name));
+        if (!library.IsNull()) {
+          return Symbols::True().raw();
+        }
+      }
+    }
+    // Check for default VM provided values. If it was not overriden on the
+    // command line.
+    if (Symbols::DartIsVM().Equals(name)) {
+      return Symbols::True().raw();
+    }
+  }
+  return result.raw();
+}
+
+
 RawString* Api::CallEnvironmentCallback(Thread* thread, const String& name) {
   Isolate* isolate = thread->isolate();
   Dart_EnvironmentCallback callback = isolate->environment_callback();
@@ -4966,15 +4995,6 @@ RawString* Api::CallEnvironmentCallback(Thread* thread, const String& name) {
           String::Handle(String::New("Illegal environment value")));
     }
   }
-  if (result.IsNull()) {
-    // TODO(iposva): Determine whether builtin values can be overriden by the
-    // embedder.
-    // Check for default VM provided values. If it was not overriden on the
-    // command line.
-    if (Symbols::DartIsVM().Equals(name)) {
-      return Symbols::True().raw();
-    }
-  }
   return result.raw();
 }