MD Settings: Fix main content position and sizing to match spec.

MD Settings: Fix main content position and sizing to match spec.

BUG=581758
Committed: https://crrev.com/491c71da6d6b3dc6bfe529d11537b667a6085ebc
Cr-Commit-Position: refs/heads/master@{#371869}

[dpapad, 2016-01-27 18:35:21]

dpapad@chromium.org changed reviewers:
+ dschuyler@chromium.org

[dpapad, 2016-01-27 18:35:22]

Before/after screenshots http://imgur.com/a/dNZ0N.

The two CSS files are identical. I am open to suggestions on how to unify them
(what should be the common file's name?, where should it reside?).

[dschuyler, 2016-01-27 19:20:23]

On 2016/01/27 18:35:22, dpapad wrote:
> Before/after screenshots http://imgur.com/a/dNZ0N.
> 
> The two CSS files are identical. I am open to suggestions on how to unify them
> (what should be the common file's name?, where should it reside?).

How about a settings/settings_page.css (or .html style-module) that holds these.

A bit of a sidebar: I kinda wish that basic/advanced had a different qualifier
(page) than
the other bits and pieces such as a11y, privacy, on_startup and so on
(which also have the qualifier 'page').  Maybe one set could be 'page' and 
the other called 'section' or 'group'.  So we'd have CSS for
settings/settings_dialog.css
settings/settings_page.css
settings/settings_<other set of things>.css

[michaelpg, 2016-01-27 19:47:13]

On 2016/01/27 19:20:23, dschuyler wrote:
> On 2016/01/27 18:35:22, dpapad wrote:
> > Before/after screenshots http://imgur.com/a/dNZ0N.
> > 
> > The two CSS files are identical. I am open to suggestions on how to unify
them
> > (what should be the common file's name?, where should it reside?).
> 
> How about a settings/settings_page.css (or .html style-module) that holds
these.

didn't we already have a settings_page.css that you deleted?

> 
> A bit of a sidebar: I kinda wish that basic/advanced had a different qualifier
> (page) than
> the other bits and pieces such as a11y, privacy, on_startup and so on
> (which also have the qualifier 'page').  Maybe one set could be 'page' and 
> the other called 'section' or 'group'.  So we'd have CSS for
> settings/settings_dialog.css
> settings/settings_page.css
> settings/settings_<other set of things>.css

[dpapad, 2016-01-27 19:53:50]

Patchset #3 (id:40001) has been deleted

[dpapad, 2016-01-27 19:54:01]

Patchset #2 (id:20001) has been deleted

[dpapad, 2016-01-27 19:58:11]

On 2016/01/27 at 19:47:13, michaelpg wrote:
> On 2016/01/27 19:20:23, dschuyler wrote:
> > On 2016/01/27 18:35:22, dpapad wrote:
> > > Before/after screenshots http://imgur.com/a/dNZ0N.
> > > 
> > > The two CSS files are identical. I am open to suggestions on how to unify
them
> > > (what should be the common file's name?, where should it reside?).
> > 
> > How about a settings/settings_page.css (or .html style-module) that holds
these.
> 
> didn't we already have a settings_page.css that you deleted?
> 
> > 
> > A bit of a sidebar: I kinda wish that basic/advanced had a different
qualifier
> > (page) than
> > the other bits and pieces such as a11y, privacy, on_startup and so on
> > (which also have the qualifier 'page').  Maybe one set could be 'page' and 
> > the other called 'section' or 'group'.  So we'd have CSS for
> > settings/settings_dialog.css
> > settings/settings_page.css
> > settings/settings_<other set of things>.css

Adding settings/settings_page.css as suggested. Deleted basic_page.css and
advanced_page.css. I agree that using page both for top-level (basic/advanced)
and for sections is confusing. Renaming will be a lot of churn, but maybe worth
it.

[dschuyler, 2016-01-27 20:04:59]

On 2016/01/27 19:47:13, michaelpg wrote:
> On 2016/01/27 19:20:23, dschuyler wrote:
> > On 2016/01/27 18:35:22, dpapad wrote:
> > > Before/after screenshots http://imgur.com/a/dNZ0N.
> > > 
> > > The two CSS files are identical. I am open to suggestions on how to unify
> them
> > > (what should be the common file's name?, where should it reside?).
> > 
> > How about a settings/settings_page.css (or .html style-module) that holds
> these.
> 
> didn't we already have a settings_page.css that you deleted?
> 
> > 
> > A bit of a sidebar: I kinda wish that basic/advanced had a different
qualifier
> > (page) than
> > the other bits and pieces such as a11y, privacy, on_startup and so on
> > (which also have the qualifier 'page').  Maybe one set could be 'page' and 
> > the other called 'section' or 'group'.  So we'd have CSS for
> > settings/settings_dialog.css
> > settings/settings_page.css
> > settings/settings_<other set of things>.css

I removed a settings_page.css that was in a different directory.
I'll likely remove this settings_page.css too, when it gets converted
to a style-module :)

[dpapad, 2016-01-27 20:15:13]

On 2016/01/27 at 20:04:59, dschuyler wrote:
> On 2016/01/27 19:47:13, michaelpg wrote:
> > On 2016/01/27 19:20:23, dschuyler wrote:
> > > On 2016/01/27 18:35:22, dpapad wrote:
> > > > Before/after screenshots http://imgur.com/a/dNZ0N.
> > > > 
> > > > The two CSS files are identical. I am open to suggestions on how to
unify
> > them
> > > > (what should be the common file's name?, where should it reside?).
> > > 
> > > How about a settings/settings_page.css (or .html style-module) that holds
> > these.
> > 
> > didn't we already have a settings_page.css that you deleted?
> > 
> > > 
> > > A bit of a sidebar: I kinda wish that basic/advanced had a different
qualifier
> > > (page) than
> > > the other bits and pieces such as a11y, privacy, on_startup and so on
> > > (which also have the qualifier 'page').  Maybe one set could be 'page' and

> > > the other called 'section' or 'group'.  So we'd have CSS for
> > > settings/settings_dialog.css
> > > settings/settings_page.css
> > > settings/settings_<other set of things>.css
> 
> I removed a settings_page.css that was in a different directory.
> I'll likely remove this settings_page.css too, when it gets converted
> to a style-module :)

Summarizing offline discussion with Dave, I prefer to land this CL as is, and
will experiment with the style-module after (if Dave has not started on that by
that time).

[dschuyler, 2016-01-27 20:15:28]

lgtm

[dpapad, 2016-01-27 20:17:22]

The CQ bit was checked by dpapad@chromium.org

[commit-bot: I haz the power, 2016-01-27 20:18:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1640843002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1640843002/80001

[commit-bot: I haz the power, 2016-01-27 21:09:06]

Committed patchset #3 (id:80001)

[commit-bot: I haz the power, 2016-01-27 21:11:28]

Description was changed from

==========
MD Settings: Fix main content position and sizing to match spec.

BUG=581758
==========

to

==========
MD Settings: Fix main content position and sizing to match spec.

BUG=581758

Committed: https://crrev.com/491c71da6d6b3dc6bfe529d11537b667a6085ebc
Cr-Commit-Position: refs/heads/master@{#371869}
==========

[commit-bot: I haz the power, 2016-01-27 21:11:29]

Patchset 3 (id:??) landed as
https://crrev.com/491c71da6d6b3dc6bfe529d11537b667a6085ebc
Cr-Commit-Position: refs/heads/master@{#371869}