Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Unified Diff: chrome/browser/ui/android/ssl_client_certificate_request.cc

Issue 1640833002: Android SSLPrivateKey Work (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix rebase. Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « android_webview/native/aw_contents_client_bridge.cc ('k') | net/ssl/ssl_platform_key_android.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/android/ssl_client_certificate_request.cc
diff --git a/chrome/browser/ui/android/ssl_client_certificate_request.cc b/chrome/browser/ui/android/ssl_client_certificate_request.cc
index 8d44cc49f76cc8d8b4bfdf15b8a1bc733eb93c4a..2af49c05bde467c03dcd0235e188fbcfdacd398c 100644
--- a/chrome/browser/ui/android/ssl_client_certificate_request.cc
+++ b/chrome/browser/ui/android/ssl_client_certificate_request.cc
@@ -150,16 +150,8 @@ static void OnSystemRequestCompletion(
return;
}
- // Create an EVP_PKEY wrapper for the private key JNI reference.
- crypto::ScopedEVP_PKEY private_key(
- net::android::GetOpenSSLPrivateKeyWrapper(private_key_ref));
- if (!private_key.get()) {
- LOG(ERROR) << "Could not create OpenSSL wrapper for private key";
- return;
- }
-
scoped_refptr<net::SSLPrivateKey> client_private_key =
- net::WrapOpenSSLPrivateKey(std::move(private_key));
+ net::WrapJavaPrivateKey(private_key_ref.obj());
content::BrowserThread::PostTask(
content::BrowserThread::IO, FROM_HERE,
« no previous file with comments | « android_webview/native/aw_contents_client_bridge.cc ('k') | net/ssl/ssl_platform_key_android.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698