Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 1640833002: Android SSLPrivateKey Work (Closed)

Created:
4 years, 11 months ago by svaldez
Modified:
3 years, 11 months ago
Reviewers:
davidben
CC:
chromium-reviews, cbentzel+watch_chromium.org, lcwu+watch_chromium.org, jam, darin-cc_chromium.org, halliwell+watch_chromium.org, devtools-reviews_chromium.org, loading-reviews_chromium.org, gunsch+watch_chromium.org, android-webview-reviews_chromium.org, pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Android SSLPrivateKey Work BUG=

Patch Set 1 #

Patch Set 2 : More testing. #

Patch Set 3 : More fixes. #

Patch Set 4 : Fix upstream. #

Patch Set 5 : More fixes. #

Patch Set 6 : Real fix for upstrewam. #

Patch Set 7 : Fix caller.s #

Patch Set 8 : Add header. #

Patch Set 9 : Remove unittest temporarily. #

Patch Set 10 : Fix testing. #

Patch Set 11 : Rebase. #

Patch Set 12 : Fix rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+147 lines, -83 lines) Patch
M android_webview/native/aw_contents_client_bridge.cc View 1 2 3 4 5 6 7 2 chunks +2 lines, -10 lines 0 comments Download
M chrome/browser/ui/android/ssl_client_certificate_request.cc View 1 2 3 4 5 6 1 chunk +1 line, -9 lines 0 comments Download
M net/ssl/ssl_platform_key_android.h View 1 2 3 4 5 1 chunk +6 lines, -4 lines 0 comments Download
M net/ssl/ssl_platform_key_android.cc View 1 2 3 4 5 2 chunks +138 lines, -60 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 2 (1 generated)
svaldez
4 years, 9 months ago (2016-02-29 16:14:23 UTC) #2
I think this is complete to review once the rest of the SPK plumbing happens
past //net. Mostly just based on your existing CL.

Powered by Google App Engine
This is Rietveld 408576698