Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(615)

Issue 1640823003: X87: [regexp] correctly advance zero length matches for global/unicode. (Closed)

Created:
4 years, 11 months ago by zhengxing.li
Modified:
4 years, 10 months ago
Reviewers:
Weiliang, chunyang.dai, Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [regexp] correctly advance zero length matches for global/unicode. port 57d202d879dbf7589a7d2c1466b2698d3a2d9c21 (r33550) original commit message: BUG= Committed: https://crrev.com/6cdf6a77ec4cc6151bdef8299f577367fce41a8e Cr-Commit-Position: refs/heads/master@{#33570}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M src/regexp/x87/regexp-macro-assembler-x87.cc View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 11 months ago (2016-01-28 03:20:58 UTC) #2
Weiliang
lgtm
4 years, 10 months ago (2016-01-28 03:58:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1640823003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1640823003/1
4 years, 10 months ago (2016-01-28 04:21:31 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-01-28 04:36:58 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-01-28 04:37:37 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6cdf6a77ec4cc6151bdef8299f577367fce41a8e
Cr-Commit-Position: refs/heads/master@{#33570}

Powered by Google App Engine
This is Rietveld 408576698