Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Unified Diff: test/mjsunit/es6/regexp-flags.js

Issue 1640803003: ES2015 web compat workaround: RegExp.prototype.flags => "" (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fix webkit test Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/js/regexp.js ('k') | test/mjsunit/regress/regress-crbug-581577.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/mjsunit/es6/regexp-flags.js
diff --git a/test/mjsunit/es6/regexp-flags.js b/test/mjsunit/es6/regexp-flags.js
index 2f1222197dc8905472084d259188e6daa5145b28..79b0197e917630c35481dd9f5256da7db484a932 100644
--- a/test/mjsunit/es6/regexp-flags.js
+++ b/test/mjsunit/es6/regexp-flags.js
@@ -50,11 +50,9 @@ assertEquals(4, get_count);
function testName(name) {
- if (name === "sticky") {
- assertEquals(undefined, RegExp.prototype[name]);
- } else {
- assertThrows(() => RegExp.prototype[name], TypeError);
- }
+ // TODO(littledan): For web compatibility, we don't throw an exception,
+ // but ES2015 expects an exception to be thrown from this getter.
+ assertEquals(undefined, RegExp.prototype[name]);
assertEquals(
"get " + name,
Object.getOwnPropertyDescriptor(RegExp.prototype, name).get.name);
« no previous file with comments | « src/js/regexp.js ('k') | test/mjsunit/regress/regress-crbug-581577.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698