src/js/harmony-unicode-regexps.js - Issue 1640803003: ES2015 web compat workaround: RegExp.prototype.flags => ""

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/js/harmony-unicode-regexps.js

Issue 1640803003: ES2015 web compat workaround: RegExp.prototype.flags => "" (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Fix webkit test Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/js/harmony-unicode-regexps.js

diff --git a/src/js/harmony-unicode-regexps.js b/src/js/harmony-unicode-regexps.js

index aa8fc76bd5eff987577e14997b01b14a82799366..b24bbdf2c545975c7455588ebc5df7c902139716 100644

--- a/src/js/harmony-unicode-regexps.js

+++ b/src/js/harmony-unicode-regexps.js

@@ -24,8 +24,10 @@ utils.Import(function(from) {

// ES6 21.2.5.15.

function RegExpGetUnicode() {

if (!IS_REGEXP(this)) {

+ // TODO(littledan): Remove this RegExp compat workaround

if (this === GlobalRegExpPrototype) {

%IncrementUseCounter(kRegExpPrototypeUnicodeGetter);

+ return UNDEFINED;

}

throw MakeTypeError(kRegExpNonRegExp, "RegExp.prototype.unicode");

}

« no previous file with comments | « no previous file | src/js/regexp.js » ('j') | no next file with comments »