Consolidate SkStream copying methods

Consolidate SkStream copying methods

Make SkCopyStreamToData call SkStreamCopy, removing duplicate code.

The former still has its own method of copying with a length, since
it saves one copy.

BUG=skia:4788
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1640793002

Committed: https://skia.googlesource.com/skia/+/440c5a98dee428c661b77d149e30c794d264b8cd

[scroggo, 2016-01-27 17:08:06]

Description was changed from

==========
Consolidate SkStream copying methods

Make SkCopyStreamToData call SkStreamCopy, removing duplicate code.

The former still has its own method of copying with a length, since
it saves one copy.

BUG=skia:4788
==========

to

==========
Consolidate SkStream copying methods

Make SkCopyStreamToData call SkStreamCopy, removing duplicate code.

The former still has its own method of copying with a length, since
it saves one copy.

BUG=skia:4788
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[scroggo, 2016-01-27 17:08:23]

scroggo@google.com changed reviewers:
+ halcanary@google.com

[hal.canary, 2016-01-27 18:39:56]

The CQ bit was checked by halcanary@google.com

[hal.canary, 2016-01-27 18:39:56]

lgtm

[commit-bot: I haz the power, 2016-01-27 18:40:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1640793002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1640793002/1

[commit-bot: I haz the power, 2016-01-27 18:51:59]

Description was changed from

==========
Consolidate SkStream copying methods

Make SkCopyStreamToData call SkStreamCopy, removing duplicate code.

The former still has its own method of copying with a length, since
it saves one copy.

BUG=skia:4788
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Consolidate SkStream copying methods

Make SkCopyStreamToData call SkStreamCopy, removing duplicate code.

The former still has its own method of copying with a length, since
it saves one copy.

BUG=skia:4788
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/440c5a98dee428c661b77d149e30c794d264b8cd
==========

[commit-bot: I haz the power, 2016-01-27 18:51:59]

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/440c5a98dee428c661b77d149e30c794d264b8cd

[msarett, 2016-01-27 20:06:09]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1641853002/ by msarett@google.com.

The reason for reverting is: Test to see if this fixes the bots..

[msarett, 2016-01-27 21:40:13]

msarett@google.com changed reviewers:
+ msarett@google.com

[msarett, 2016-01-27 21:40:13]

The bots seem happier, though I'm unsure if reverting this CL is what fixed
them.

Perhaps we'll know more tomorrow when they backfill.

[msarett, 2016-01-28 15:28:24]

I've circled back to this and still don't really understand how/if this caused a
problem.

The log messages on the bots don't say much.
https://uberchromegw.corp.google.com/i/client.skia/builders/Test-Win8-MSVC-Sh...

Fine with me if you want to try to reland.

[hal.canary, 2016-01-28 15:36:30]

On 2016/01/28 at 15:28:24, msarett wrote:
> I've circled back to this and still don't really understand how/if this caused
a problem.
> 
> The log messages on the bots don't say much.
>
https://uberchromegw.corp.google.com/i/client.skia/builders/Test-Win8-MSVC-Sh...
> 
> Fine with me if you want to try to reland.

This would more closely replicate previous behavior:

    (void)SkStreamCopy(&tempStream, stream);
    return tempStream.copyToData();

Can we try that with the effected bots?