Issue 164071: Merge 22540 - Ensure that we never call into WebCore::Page static methods whe...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 164071: Merge 22540 - Ensure that we never call into WebCore::Page static methods whe... (Closed)

Created:
11 years, 4 months ago by jon

Modified:
9 years, 7 months ago

Reviewers:
dglazkov

CC:
chromium-reviews_googlegroups.com, darin (slow to review), brettw, jam, Ben Goodger (Google)

Base URL:
svn://chrome-svn/chrome/branches/197/src/

Visibility:
Public.

Description

Merge 22540 - Ensure that we never call into WebCore::Page static methods when Page constructor hasn't been called. This is a top crash for Mac right now. The crash occurs because the static table of all pages in the renderer is initialized in WebCore:: Page constructor, and if we attempt to access this table before the Page was created (i.e. before WebView::Create is called), we get into a crashy situation. I am really not sure how to reproduce this, but I can defend against the situation. BUG=17555 R=darin TEST=unable to repro, speculative fix. Review URL: http://codereview.chromium.org/159887 TBR=dglazkov@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=22618

Patch Set 1 #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+22 lines, -1 line)			Patch
MM	chrome/browser/renderer_host/browser_render_process_host.h	View	2 chunks	+4 lines, -0 lines	0 comments	Download
MM	chrome/browser/renderer_host/browser_render_process_host.cc	View	2 chunks	+8 lines, -1 line	0 comments	Download
MM	chrome/browser/renderer_host/mock_render_process_host.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
MM	chrome/browser/renderer_host/mock_render_process_host.cc	View	1 chunk	+3 lines, -0 lines	0 comments	Download
MM	chrome/browser/renderer_host/render_process_host.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
MM	chrome/browser/renderer_host/render_view_host.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
MM	chrome/browser/renderer_host/test/test_render_view_host.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
MM	chrome/browser/visitedlink_unittest.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages