Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issue 1640703002: ppapi: examples: audio_encode: fix opus comments (Closed)

Created:
4 years, 11 months ago by llandwerlin-old
Modified:
4 years, 11 months ago
Reviewers:
bbudge
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ppapi: examples: audio_encode: fix opus comments The genereated Ogg/Opus files don't seem to play in Chromium (which uses ffmpeg) while they do VLC or Gstreamer. Turns out we have the wrong flag set on the OpusTags packet and a wrong size written for one of the strings. BUG=none TEST=play the generated file on Chromium Committed: https://crrev.com/67bd3bd3dc4915772ed0f525a84630a88c5ccce9 Cr-Commit-Position: refs/heads/master@{#371778}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M ppapi/examples/audio_encode/audio_encode.html View 2 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
llandwerlin-old
Hi Bill, PTAL, Here is a quick fix to make the generated Ogg files play ...
4 years, 11 months ago (2016-01-27 12:27:35 UTC) #2
bbudge
lgtm
4 years, 11 months ago (2016-01-27 12:39:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1640703002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1640703002/1
4 years, 11 months ago (2016-01-27 12:41:07 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-27 13:00:50 UTC) #9
commit-bot: I haz the power
4 years, 11 months ago (2016-01-27 13:01:53 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/67bd3bd3dc4915772ed0f525a84630a88c5ccce9
Cr-Commit-Position: refs/heads/master@{#371778}

Powered by Google App Engine
This is Rietveld 408576698