Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 1640683002: [interpreter] Fix BytecodeGraphBuilder for disabled deopt. (Closed)

Created:
4 years, 11 months ago by Michael Starzinger
Modified:
4 years, 11 months ago
Reviewers:
Jarin, rmcilroy
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[interpreter] Fix BytecodeGraphBuilder for disabled deopt. This ensures that the BytecodeGraphBuilder can generate correct graphs even when deoptimization has not been enabled. This configuration is not enabled in production, and we might eventually decide to deprecate it for good. Until then, this is a quick fix. R=jarin@chromium.org TEST=cctest/test-pipeline Committed: https://crrev.com/e3014ad848daa2d806147dcf838587c968b639e4 Cr-Commit-Position: refs/heads/master@{#33545}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M src/compiler/bytecode-graph-builder.cc View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/cctest.status View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Michael Starzinger
Jaro: PTAL. Ross: FYI.
4 years, 11 months ago (2016-01-27 09:54:09 UTC) #2
rmcilroy
lgtm
4 years, 11 months ago (2016-01-27 09:59:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1640683002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1640683002/1
4 years, 11 months ago (2016-01-27 12:06:03 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-27 12:07:31 UTC) #6
commit-bot: I haz the power
4 years, 11 months ago (2016-01-27 12:08:36 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e3014ad848daa2d806147dcf838587c968b639e4
Cr-Commit-Position: refs/heads/master@{#33545}

Powered by Google App Engine
This is Rietveld 408576698