third_party/WebKit/Source/core/animation/animatable/AnimatableLengthBox.cpp - Issue 1640643002: Add additive animation support for CSS property clip

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/animation/animatable/AnimatableLengthBox.cpp

Issue 1640643002: Add additive animation support for CSS property clip (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@_propertyInterpolationTypesMapping

Patch Set: Moar tests Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/animation/CSSClipInterpolationType.cpp ('K') | « third_party/WebKit/Source/core/animation/animatable/AnimatableLengthBox.h ('k') | third_party/WebKit/Source/core/core.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/animation/animatable/AnimatableLengthBox.cpp

diff --git a/third_party/WebKit/Source/core/animation/animatable/AnimatableLengthBox.cpp b/third_party/WebKit/Source/core/animation/animatable/AnimatableLengthBox.cpp

index be07069bfbecb24944543f0cfad3a69168f807b5..172a921312d35633303c4c8a6ac05f48935d3569 100644

--- a/third_party/WebKit/Source/core/animation/animatable/AnimatableLengthBox.cpp

+++ b/third_party/WebKit/Source/core/animation/animatable/AnimatableLengthBox.cpp

@@ -42,6 +42,15 @@ PassRefPtr<AnimatableValue> AnimatableLengthBox::interpolateTo(const AnimatableV

AnimatableValue::interpolate(this->bottom(), lengthBox->bottom(), fraction));

}

+bool AnimatableLengthBox::usesDefaultInterpolationWith(const AnimatableValue* other) const

+ const AnimatableLengthBox& otherBox = toAnimatableLengthBox(*other);

+ return usesDefaultInterpolation(left(), otherBox.left())

+ || usesDefaultInterpolation(right(), otherBox.right())

+ || usesDefaultInterpolation(top(), otherBox.top())

+ || usesDefaultInterpolation(bottom(), otherBox.bottom());

bool AnimatableLengthBox::equalTo(const AnimatableValue* value) const

{

const AnimatableLengthBox* lengthBox = toAnimatableLengthBox(value);