Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 1640623002: Move SelectionAdjust to its own file (Closed)

Created:
4 years, 11 months ago by yosin_UTC9
Modified:
4 years, 11 months ago
Reviewers:
tkent
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move SelectionAdjuster to its own file This patch moves implementations of |SelectionAdjuster| into its own file. This is a follow-up patch of http://crrev.com/1630903005, which introduces |SelectionAdjuster| into "SelectionEditor.cpp" and "VisibleSelection.cpp". BUG=n/a TEST=n/a; no behavior changes Committed: https://crrev.com/da8f47a0153b025331e2c8ed62c4f6510c63c703 Cr-Commit-Position: refs/heads/master@{#371751}

Patch Set 1 : 2016-01-27T13:38:54 #

Total comments: 2

Patch Set 2 : 2016-01-27T14:51:58 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+304 lines, -259 lines) Patch
M third_party/WebKit/Source/core/core.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/editing/SelectionAdjuster.h View 1 chunk +27 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/editing/SelectionAdjuster.cpp View 1 1 chunk +273 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/SelectionEditor.cpp View 2 chunks +1 line, -77 lines 0 comments Download
M third_party/WebKit/Source/core/editing/VisibleSelection.h View 1 chunk +0 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/editing/VisibleSelection.cpp View 3 chunks +1 line, -172 lines 0 comments Download

Messages

Total messages: 19 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1640623002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1640623002/1
4 years, 11 months ago (2016-01-27 04:50:45 UTC) #3
yosin_UTC9
PTAL
4 years, 11 months ago (2016-01-27 05:06:15 UTC) #6
tkent
https://codereview.chromium.org/1640623002/diff/1/third_party/WebKit/Source/core/editing/SelectionAdjuster.cpp File third_party/WebKit/Source/core/editing/SelectionAdjuster.cpp (right): https://codereview.chromium.org/1640623002/diff/1/third_party/WebKit/Source/core/editing/SelectionAdjuster.cpp#newcode1 third_party/WebKit/Source/core/editing/SelectionAdjuster.cpp:1: // Copyright 2016 The Chromium Authors. All rights reserved. ...
4 years, 11 months ago (2016-01-27 05:12:48 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1640623002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1640623002/20001
4 years, 11 months ago (2016-01-27 05:57:21 UTC) #9
yosin_UTC9
PTAL I copied copyright header from SelectionEdtior.cpp, which has more years than VisibleSelection.cpp to SelectionAdjuster.cpp. ...
4 years, 11 months ago (2016-01-27 05:58:23 UTC) #10
yosin_UTC9
PTAL
4 years, 11 months ago (2016-01-27 05:58:30 UTC) #11
tkent
lgtm
4 years, 11 months ago (2016-01-27 06:16:09 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1640623002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1640623002/20001
4 years, 11 months ago (2016-01-27 06:17:38 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-27 07:22:03 UTC) #16
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/da8f47a0153b025331e2c8ed62c4f6510c63c703 Cr-Commit-Position: refs/heads/master@{#371751}
4 years, 11 months ago (2016-01-27 07:22:59 UTC) #18
lushnikov
4 years, 11 months ago (2016-01-27 20:13:35 UTC) #19
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1640913002/ by lushnikov@chromium.org.

The reason for reverting is: This refactoring breaks text selection in DevTools
console. Please see http://crbug.com/581800 for details.

Powered by Google App Engine
This is Rietveld 408576698