PNaCl cleanup: Reuse base::File for closing a handle/FD

PNaCl cleanup: Reuse base::File for closing a handle/FD

This removes a dependency on the NACL_WINDOWS macro, which is defined
in non-public native_client headers.

It also gets the benefit of the error-checking that base/ does for
close()/CloseHandle().

BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=2832
TEST=e.g. NaClBrowserTestPnacl.PPAPICore (tests PNaCl translation)

Committed: https://crrev.com/a751ae0a7ecea5856b4e2071e66a829e835111fc
Cr-Commit-Position: refs/heads/master@{#371692}

[Mark Seaborn, 2016-01-27 00:14:42]

The CQ bit was checked by mseaborn@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-27 00:16:20]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1640523002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1640523002/1

[Mark Seaborn, 2016-01-27 01:04:19]

mseaborn@chromium.org changed reviewers:
+ bbudge@chromium.org

[commit-bot: I haz the power, 2016-01-27 01:07:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-27 01:07:41]

Dry run: This issue passed the CQ dry run.

[bbudge, 2016-01-27 01:41:35]

lgtm

[Mark Seaborn, 2016-01-27 02:14:42]

The CQ bit was checked by mseaborn@chromium.org

[commit-bot: I haz the power, 2016-01-27 02:15:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1640523002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1640523002/1

[commit-bot: I haz the power, 2016-01-27 02:22:16]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-01-27 02:23:15]

Description was changed from

==========
PNaCl cleanup: Reuse base::File for closing a handle/FD

This removes a dependency on the NACL_WINDOWS macro, which is defined
in non-public native_client headers.

It also gets the benefit of the error-checking that base/ does for
close()/CloseHandle().

BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=2832
TEST=e.g. NaClBrowserTestPnacl.PPAPICore (tests PNaCl translation)
==========

to

==========
PNaCl cleanup: Reuse base::File for closing a handle/FD

This removes a dependency on the NACL_WINDOWS macro, which is defined
in non-public native_client headers.

It also gets the benefit of the error-checking that base/ does for
close()/CloseHandle().

BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=2832
TEST=e.g. NaClBrowserTestPnacl.PPAPICore (tests PNaCl translation)

Committed: https://crrev.com/a751ae0a7ecea5856b4e2071e66a829e835111fc
Cr-Commit-Position: refs/heads/master@{#371692}
==========

[commit-bot: I haz the power, 2016-01-27 02:23:15]

Patchset 1 (id:??) landed as
https://crrev.com/a751ae0a7ecea5856b4e2071e66a829e835111fc
Cr-Commit-Position: refs/heads/master@{#371692}