Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(357)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1640503003: Remove unused foreground member variable from SB Protocol Manager. (Closed)

Created:
4 years, 11 months ago by kcarattini
Modified:
4 years, 11 months ago
CC:
chromium-reviews, grt+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused foreground member variable from SB Protocol Manager. BUG=543161, 561867 Committed: https://crrev.com/ab09c80991a9dffc0a37c92e54c2e57f9deca8b4 Cr-Commit-Position: refs/heads/master@{#371897}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -38 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ChromeApplication.java View 3 chunks +0 lines, -7 lines 0 comments Download
M chrome/browser/android/chrome_application.cc View 3 chunks +0 lines, -21 lines 0 comments Download
M chrome/browser/safe_browsing/protocol_manager.h View 2 chunks +0 lines, -8 lines 0 comments Download
M chrome/browser/safe_browsing/protocol_manager.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1640503003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1640503003/1
4 years, 11 months ago (2016-01-27 03:14:03 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-27 04:09:20 UTC) #4
kcarattini
newt@: Please review chrome_application.cc and ChromeApplication.java
4 years, 11 months ago (2016-01-27 04:17:34 UTC) #6
newt (away)
lgtm
4 years, 11 months ago (2016-01-27 04:43:58 UTC) #7
Nathan Parker
lgtm
4 years, 11 months ago (2016-01-27 17:52:52 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1640503003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1640503003/1
4 years, 11 months ago (2016-01-27 22:19:43 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-27 22:27:58 UTC) #11
commit-bot: I haz the power
4 years, 11 months ago (2016-01-27 22:30:14 UTC) #13
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/ab09c80991a9dffc0a37c92e54c2e57f9deca8b4
Cr-Commit-Position: refs/heads/master@{#371897}

Powered by Google App Engine
This is Rietveld 408576698