ash/wm/workspace/workspace_event_handler_unittest.cc - Issue 1640503002: ash: Do not use MessageLoopForUI when not needed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/wm/workspace/workspace_event_handler_unittest.cc

Issue 1640503002: ash: Do not use MessageLoopForUI when not needed. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ash/wm/workspace/workspace_event_handler_unittest.cc

diff --git a/ash/wm/workspace/workspace_event_handler_unittest.cc b/ash/wm/workspace/workspace_event_handler_unittest.cc

index 5f1e48f1bc407d3d5ed2a3bab5e64ec7fd4ce6a9..ce2de8932cbd5a97001036dbdbbf202e4fd6d7dd 100644

--- a/ash/wm/workspace/workspace_event_handler_unittest.cc

+++ b/ash/wm/workspace/workspace_event_handler_unittest.cc

@@ -12,6 +12,7 @@

#include "ash/wm/wm_event.h"

#include "ash/wm/workspace_controller.h"

#include "ash/wm/workspace_controller_test_helper.h"

+#include "base/thread_task_runner_handle.h"

#include "ui/aura/client/aura_constants.h"

#include "ui/aura/test/test_window_delegate.h"

#include "ui/aura/window.h"

@@ -453,7 +454,7 @@ TEST_F(WorkspaceEventHandlerTest, DeleteWhileInRunLoop) {

delegate.set_window_component(HTCAPTION);

ASSERT_TRUE(aura::client::GetWindowMoveClient(window->GetRootWindow()));

- base::MessageLoop::current()->DeleteSoon(FROM_HERE, window.get());

+ base::ThreadTaskRunnerHandle::Get()->DeleteSoon(FROM_HERE, window.get());

aura::client::GetWindowMoveClient(window->GetRootWindow())

->RunMoveLoop(window.release(),

gfx::Vector2d(),