Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Unified Diff: tools/chrome_proxy/integration_tests/chrome_proxy_metrics.py

Issue 1640483002: Remove "client_version" test from chromium (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/chrome_proxy/integration_tests/chrome_proxy_measurements.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/chrome_proxy/integration_tests/chrome_proxy_metrics.py
diff --git a/tools/chrome_proxy/integration_tests/chrome_proxy_metrics.py b/tools/chrome_proxy/integration_tests/chrome_proxy_metrics.py
index 3518f11647ea6661981dda675124663ac0a771f7..e053f19e2341ebc4356610bd6f92af36aaf0baf6 100644
--- a/tools/chrome_proxy/integration_tests/chrome_proxy_metrics.py
+++ b/tools/chrome_proxy/integration_tests/chrome_proxy_metrics.py
@@ -170,25 +170,6 @@ class ChromeProxyMetric(network_metrics.NetworkMetric):
results.AddValue(scalar.ScalarValue(
results.current_page, 'extra_via_header', 'count', extra_via_count))
- def AddResultsForClientVersion(self, tab, results):
- via_count = 0
- for resp in self.IterResponses(tab):
- r = resp.response
- if resp.response.status != 200:
- raise ChromeProxyMetricException, ('%s: Response is not 200: %d' %
- (r.url, r.status))
- if not resp.IsValidByViaHeader():
- raise ChromeProxyMetricException, ('%s: Response missing via header' %
- (r.url))
- via_count += 1
-
- if via_count == 0:
- raise ChromeProxyMetricException, (
- 'Expected at least one response through the proxy, but zero such '
- 'responses were received.')
- results.AddValue(scalar.ScalarValue(
- results.current_page, 'responses_via_proxy', 'count', via_count))
-
def GetClientTypeFromRequests(self, tab):
"""Get the Chrome-Proxy client type value from requests made in this tab.
« no previous file with comments | « tools/chrome_proxy/integration_tests/chrome_proxy_measurements.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698