Unprefix -webkit-min-content and -webkit-max-content for grid layout

Unprefix -webkit-min-content and -webkit-max-content for grid layout

This change adds the unprefixed version of the 2 values so that grid
layout can use them. As the parsing / style resolution changes are
grid specific, the impact of this is very minimal.

The only impact outside grid is the following:

element.style.width = "-webkit-min-content";
width = window.getComputedStyle(element, null).getPropertyValue("width")

|width| was "-webkit-min-content" before this change but now will be
"min-content". Same for -webkit-max-content.

TESTS=LayoutTests/fast/css-grid-layout/
BUG=245878
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=153111

[ojan, 2013-06-26 21:34:14]

lgtm

This is fine. I'd also be fine with us unprefixing the intrinsic size keywords
too. I'm sure we still have bugs there, but I don't think there's any more we're
realistically going to find/fix between now and when the spec is more stable.

https://codereview.chromium.org/16404015/diff/1/Source/core/css/CSSValueKeywo...
File Source/core/css/CSSValueKeywords.in (right):

https://codereview.chromium.org/16404015/diff/1/Source/core/css/CSSValueKeywo...
Source/core/css/CSSValueKeywords.in:584: // Unprefixed for CSS Grid Layout.
Incidentally, grid's minmax should probably support fill-available and
fit-content as well. Don't see any reason not to. That requires a www-style
email and would be a different patch obviously. Just mentioning it while I
noticed it.

[commit-bot: I haz the power, 2013-06-26 21:34:32]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jchaffraix@chromium.org/16404015/1

[commit-bot: I haz the power, 2013-06-26 21:34:47]

Failed to apply patch for
LayoutTests/fast/css-grid-layout/named-grid-line-get-set-expected.txt:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file
LayoutTests/fast/css-grid-layout/named-grid-line-get-set-expected.txt
  Hunk #1 FAILED at 24.
  1 out of 1 hunk FAILED -- saving rejects to file
LayoutTests/fast/css-grid-layout/named-grid-line-get-set-expected.txt.rej

Patch:      
LayoutTests/fast/css-grid-layout/named-grid-line-get-set-expected.txt
Index: LayoutTests/fast/css-grid-layout/named-grid-line-get-set-expected.txt
diff --git
a/LayoutTests/fast/css-grid-layout/named-grid-line-get-set-expected.txt
b/LayoutTests/fast/css-grid-layout/named-grid-line-get-set-expected.txt
index
a2874ffe7e9e5637a0117886ea2fd9b5cc8ec07b..59ef955833fb534e99c6ca5631bcb3e3b04e9f47
100644
--- a/LayoutTests/fast/css-grid-layout/named-grid-line-get-set-expected.txt
+++ b/LayoutTests/fast/css-grid-layout/named-grid-line-get-set-expected.txt
@@ -24,22 +24,22 @@ PASS getComputedStyle(gridElement,
'').getPropertyValue('grid-columns') is "firs
 PASS getComputedStyle(gridElement, '').getPropertyValue('grid-rows') is "40%
last"
 PASS getComputedStyle(gridElement, '').getPropertyValue('grid-columns') is
"first auto"
 PASS getComputedStyle(gridElement, '').getPropertyValue('grid-rows') is "auto
last"
-PASS getComputedStyle(gridElement, '').getPropertyValue('grid-columns') is
"first -webkit-min-content"
-PASS getComputedStyle(gridElement, '').getPropertyValue('grid-rows') is
"-webkit-min-content last"
-PASS getComputedStyle(gridElement, '').getPropertyValue('grid-columns') is
"first -webkit-max-content"
-PASS getComputedStyle(gridElement, '').getPropertyValue('grid-rows') is
"-webkit-max-content last"
+PASS getComputedStyle(gridElement, '').getPropertyValue('grid-columns') is
"first min-content"
+PASS getComputedStyle(gridElement, '').getPropertyValue('grid-rows') is
"min-content last"
+PASS getComputedStyle(gridElement, '').getPropertyValue('grid-columns') is
"first max-content"
+PASS getComputedStyle(gridElement, '').getPropertyValue('grid-rows') is
"max-content last"
 PASS getComputedStyle(gridElement, '').getPropertyValue('grid-columns') is
"first minmax(55%, 45px)"
 PASS getComputedStyle(gridElement, '').getPropertyValue('grid-rows') is
"minmax(30px, 40%) last"
-PASS getComputedStyle(gridElement, '').getPropertyValue('grid-columns') is
"first minmax(220px, -webkit-max-content)"
-PASS getComputedStyle(gridElement, '').getPropertyValue('grid-rows') is
"minmax(-webkit-max-content, 50px) last"
-PASS getComputedStyle(gridElement, '').getPropertyValue('grid-columns') is
"first minmax(220px, -webkit-max-content)"
-PASS getComputedStyle(gridElement, '').getPropertyValue('grid-rows') is
"minmax(-webkit-max-content, 50px) last"
-PASS getComputedStyle(gridElement, '').getPropertyValue('grid-columns') is
"first minmax(-webkit-min-content, -webkit-max-content)"
-PASS getComputedStyle(gridElement, '').getPropertyValue('grid-rows') is
"minmax(-webkit-max-content, -webkit-min-content) last"
-PASS getComputedStyle(gridElement, '').getPropertyValue('grid-columns') is "nav
first minmax(-webkit-min-content, -webkit-max-content) last"
-PASS getComputedStyle(gridElement, '').getPropertyValue('grid-rows') is "nav
first minmax(-webkit-max-content, -webkit-min-content) last"
-PASS getComputedStyle(gridElement, '').getPropertyValue('grid-columns') is "nav
first minmax(-webkit-min-content, -webkit-max-content) nav auto last"
-PASS getComputedStyle(gridElement, '').getPropertyValue('grid-rows') is "first
nav2 minmax(-webkit-max-content, -webkit-min-content) nav2 minmax(10px, 15px)
last"
+PASS getComputedStyle(gridElement, '').getPropertyValue('grid-columns') is
"first minmax(220px, max-content)"
+PASS getComputedStyle(gridElement, '').getPropertyValue('grid-rows') is
"minmax(max-content, 50px) last"
+PASS getComputedStyle(gridElement, '').getPropertyValue('grid-columns') is
"first minmax(220px, max-content)"
+PASS getComputedStyle(gridElement, '').getPropertyValue('grid-rows') is
"minmax(max-content, 50px) last"
+PASS getComputedStyle(gridElement, '').getPropertyValue('grid-columns') is
"first minmax(min-content, max-content)"
+PASS getComputedStyle(gridElement, '').getPropertyValue('grid-rows') is
"minmax(max-content, min-content) last"
+PASS getComputedStyle(gridElement, '').getPropertyValue('grid-columns') is "nav
first minmax(min-content, max-content) last"
+PASS getComputedStyle(gridElement, '').getPropertyValue('grid-rows') is "nav
first minmax(max-content, min-content) last"
+PASS getComputedStyle(gridElement, '').getPropertyValue('grid-columns') is "nav
first minmax(min-content, max-content) nav auto last"
+PASS getComputedStyle(gridElement, '').getPropertyValue('grid-rows') is "first
nav2 minmax(max-content, min-content) nav2 minmax(10px, 15px) last"
 PASS getComputedStyle(gridElement, '').getPropertyValue('grid-columns') is "foo
bar auto foo auto bar"
 PASS getComputedStyle(gridElement, '').getPropertyValue('grid-rows') is "foo
bar auto foo auto bar"

[cbiesinger, 2013-06-26 23:50:12]

On 2013/06/26 21:34:14, ojan wrote:
> lgtm
> 
> This is fine. I'd also be fine with us unprefixing the intrinsic size keywords
> too. I'm sure we still have bugs there, but I don't think there's any more
we're
> realistically going to find/fix between now and when the spec is more stable.

Unprefixing and enabling by default? I'd be hesitant to ship a spec that's still
just a WD...

[Julien - ping for review, 2013-06-27 00:39:49]

On 2013/06/26 23:50:12, cbiesinger wrote:
> On 2013/06/26 21:34:14, ojan wrote:
> > lgtm
> > 
> > This is fine. I'd also be fine with us unprefixing the intrinsic size
keywords
> > too. I'm sure we still have bugs there, but I don't think there's any more
> we're
> > realistically going to find/fix between now and when the spec is more
stable.
> 
> Unprefixing and enabling by default? I'd be hesitant to ship a spec that's
still
> just a WD...

Let's keep the full unprefixing / enabling by default for another bug (I agree
that it's probably too early for that).

[commit-bot: I haz the power, 2013-06-27 00:40:08]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jchaffraix@chromium.org/16404015/10001

[commit-bot: I haz the power, 2013-06-27 03:21:19]

Change committed as 153111