Do not create instance just to expose SyncService methods from sync_service.js

chrome/browser/resources/sync_file_system_internals/sync_service.js

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * WebUI to monitor the Sync File System Service.
  */
 var syncService = (function() {
 'use strict';
 
 function SyncService() {

[Bernhard Bauer, 2013/06/10 14:18:49]

SyncService doesn't need to be a function now, it can just start out as an empty
object.

[kinuko, 2013/06/10 14:44:26]

Done.

 }
 
 /**
  * Request Sync Service Status.
  */
 function getServiceStatus() {
   chrome.send('getServiceStatus');
 }
 
 /**
  * Handles callback from getServiceStatus.
  * @param {string} Service status enum as a string.
  */
-SyncService.prototype.onGetServiceStatus = function(statusString) {
+SyncService.onGetServiceStatus = function(statusString) {
   $('service-status').textContent = statusString;
 }
 
 /**
  * Request Google Drive Notification Source. e.g. XMPP or polling.
  */
 function getNotificationSource() {
   chrome.send('getNotificationSource');
 }
 
 /**
  * Handles callback from getNotificationSource.
  * @param {string} Notification source as a string.
  */
-SyncService.prototype.onGetNotificationSource = function(sourceString) {
+SyncService.onGetNotificationSource = function(sourceString) {
   $('notification-source').textContent = sourceString;
 }
 
 /**
  * Creates an element named |elementName| containing the content |text|.
  * @param {string} elementName Name of the new element to be created.
  * @param {string} text Text to be contained in the new element.
  * @return {HTMLElement} The newly created HTML element.
  */
 function createElementFromText(elementName, text) {
   var element = document.createElement(elementName);
   element.appendChild(document.createTextNode(text));
   return element;
 }
 
 /**
  * Request debug log.
  */
 function getLog() {
   chrome.send('getLog');
 }
 
 /**
  * Handles callback from getUpdateLog.
  * @param {Array} list List of dictionaries containing 'time' and 'logEvent'.
  */
-SyncService.prototype.onGetLog = function(logEntries) {
+SyncService.onGetLog = function(logEntries) {
   var itemContainer = $('log-entries');
   for (var i = 0; i < logEntries.length; i++) {
     var logEntry = logEntries[i];
     var tr = document.createElement('tr');
     tr.appendChild(createElementFromText('td', logEntry.time));
     tr.appendChild(createElementFromText('td', logEntry.logEvent));
     itemContainer.appendChild(tr);
   }
 }
 
 /**
  * Get initial sync service values and set listeners to get updated values.
  */
 function main() {
   cr.ui.decorate('tabbox', cr.ui.TabBox);
   getServiceStatus();
   getNotificationSource();
   window.setInterval(getLog, 1000);

[Bernhard Bauer, 2013/06/10 14:18:49]

This makes me sad. Can't we push entries to the page when they happen (maybe
applying some throttling browser-side)?

[kinuko, 2013/06/10 14:44:26]

Right, we're aware that it's not the ideal behavior... it's not very
straightforward to fix that way, I've added TODO for now.

 }
 
 document.addEventListener('DOMContentLoaded', main);
-return new SyncService;
+return SyncService;
 })();