Do not create instance just to expose SyncService methods from sync_service.js

Do not create instance just to expose SyncService methods from sync_service.js

BUG=none
TEST=manual (launch cloud editor, open chrome://syncfs-internals/ to see the status
NOTRY=true

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=205216

[Bernhard Bauer, 2013-06-10 14:18:49]

LGTM with a nit and a yak wanting to be shaved:

https://codereview.chromium.org/16404008/diff/1/chrome/browser/resources/sync...
File chrome/browser/resources/sync_file_system_internals/sync_service.js
(right):

https://codereview.chromium.org/16404008/diff/1/chrome/browser/resources/sync...
chrome/browser/resources/sync_file_system_internals/sync_service.js:11: function
SyncService() {
SyncService doesn't need to be a function now, it can just start out as an empty
object.

https://codereview.chromium.org/16404008/diff/1/chrome/browser/resources/sync...
chrome/browser/resources/sync_file_system_internals/sync_service.js:85:
window.setInterval(getLog, 1000);
This makes me sad. Can't we push entries to the page when they happen (maybe
applying some throttling browser-side)?

[kinuko, 2013-06-10 14:44:26]

Thx! Will be submitting.

(+cc calvin and others, it's for cleaning up what I've introduced in my
wrong-ish review comment)

https://codereview.chromium.org/16404008/diff/1/chrome/browser/resources/sync...
File chrome/browser/resources/sync_file_system_internals/sync_service.js
(right):

https://codereview.chromium.org/16404008/diff/1/chrome/browser/resources/sync...
chrome/browser/resources/sync_file_system_internals/sync_service.js:11: function
SyncService() {
On 2013/06/10 14:18:49, Bernhard Bauer wrote:
> SyncService doesn't need to be a function now, it can just start out as an
empty
> object.

Done.

https://codereview.chromium.org/16404008/diff/1/chrome/browser/resources/sync...
chrome/browser/resources/sync_file_system_internals/sync_service.js:85:
window.setInterval(getLog, 1000);
On 2013/06/10 14:18:49, Bernhard Bauer wrote:
> This makes me sad. Can't we push entries to the page when they happen (maybe
> applying some throttling browser-side)?

Right, we're aware that it's not the ideal behavior... it's not very
straightforward to fix that way, I've added TODO for now.

[commit-bot: I haz the power, 2013-06-10 15:25:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kinuko@chromium.org/16404008/19001

[commit-bot: I haz the power, 2013-06-10 15:25:26]

Change committed as 205216