Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 16404008: Do not create instance just to expose SyncService methods from sync_service.js (Closed)

Created:
7 years, 6 months ago by kinuko
Modified:
7 years, 6 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews, arv+watch_chromium.org, calvinlo, tzik, nhiroki
Visibility:
Public.

Description

Do not create instance just to expose SyncService methods from sync_service.js BUG=none TEST=manual (launch cloud editor, open chrome://syncfs-internals/ to see the status NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=205216

Patch Set 1 #

Total comments: 4

Patch Set 2 : addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -6 lines) Patch
M chrome/browser/resources/sync_file_system_internals/sync_service.js View 1 5 chunks +7 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Bernhard Bauer
LGTM with a nit and a yak wanting to be shaved: https://codereview.chromium.org/16404008/diff/1/chrome/browser/resources/sync_file_system_internals/sync_service.js File chrome/browser/resources/sync_file_system_internals/sync_service.js (right): ...
7 years, 6 months ago (2013-06-10 14:18:49 UTC) #1
kinuko
Thx! Will be submitting. (+cc calvin and others, it's for cleaning up what I've introduced ...
7 years, 6 months ago (2013-06-10 14:44:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinuko@chromium.org/16404008/19001
7 years, 6 months ago (2013-06-10 15:25:01 UTC) #3
commit-bot: I haz the power
7 years, 6 months ago (2013-06-10 15:25:26 UTC) #4
Message was sent while issue was closed.
Change committed as 205216

Powered by Google App Engine
This is Rietveld 408576698