Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Issue 1640393002: [turbofan] Add support for Math.round to the JSBuiltinReducer. (Closed)

Created:
4 years, 11 months ago by Benedikt Meurer
Modified:
4 years, 10 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Add support for Math.round to the JSBuiltinReducer. We can reduce Math.round(v) to a sequence of let i = Float64RoundUp(v); let r = i - v; return r > 0.5 ? 1.0 + i : i; if the target supports the Float64RoundUp machine operator (i.e. roundsd with RoundUp rounding on Intel processors with SSE4.1). R=jarin@chromium.org Committed: https://crrev.com/f8ece9a01384d83737ba7f79999fc95bf5529efa Cr-Commit-Position: refs/heads/master@{#33572}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -4 lines) Patch
M src/compiler/js-builtin-reducer.h View 3 chunks +7 lines, -1 line 0 comments Download
M src/compiler/js-builtin-reducer.cc View 4 chunks +32 lines, -3 lines 0 comments Download
M src/compiler/simplified-lowering.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Benedikt Meurer
4 years, 11 months ago (2016-01-27 18:38:04 UTC) #1
Benedikt Meurer
Hey Jaro, Another easy one. We're even better than Crankshaft in this case, which just ...
4 years, 11 months ago (2016-01-27 18:39:44 UTC) #2
Jarin
lgtm
4 years, 10 months ago (2016-01-28 05:19:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1640393002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1640393002/1
4 years, 10 months ago (2016-01-28 05:21:08 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-01-28 05:23:12 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-01-28 05:23:23 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f8ece9a01384d83737ba7f79999fc95bf5529efa
Cr-Commit-Position: refs/heads/master@{#33572}

Powered by Google App Engine
This is Rietveld 408576698