Wire up JsonCanvas in skiaserve

Wire up JsonCanvas in skiaserve

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1640333002

Committed: https://skia.googlesource.com/skia/+/609d97918788c077514f190b0f1087ccbd420f5d

[joshua.litt, 2016-01-27 16:53:26]

Description was changed from

==========
Wire up JsonCanvas in skiaserve

BUG=skia:
==========

to

==========
Wire up JsonCanvas in skiaserve

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[joshualitt, 2016-01-27 16:54:11]

joshualitt@google.com changed reviewers:
+ ethannicholas@google.com, jcgregorio@google.com, joshualitt@google.com

[joshualitt, 2016-01-27 16:54:11]

ptal

[jcgregorio, 2016-01-27 17:32:16]

https://codereview.chromium.org/1640333002/diff/1/tools/skiaserve/skiaserve.cpp
File tools/skiaserve/skiaserve.cpp (right):

https://codereview.chromium.org/1640333002/diff/1/tools/skiaserve/skiaserve.c...
tools/skiaserve/skiaserve.cpp:241: fHandlers.push_back({MHD_HTTP_METHOD_GET,
"/info", infoHandler});
Shouldn't this be wired to /cmd since that's where the JSON for all the
individual command comes from. The /info endpoint should just be high level info
like clip and CTM.

[joshualitt, 2016-01-27 17:43:04]

https://codereview.chromium.org/1640333002/diff/1/tools/skiaserve/skiaserve.cpp
File tools/skiaserve/skiaserve.cpp (right):

https://codereview.chromium.org/1640333002/diff/1/tools/skiaserve/skiaserve.c...
tools/skiaserve/skiaserve.cpp:241: fHandlers.push_back({MHD_HTTP_METHOD_GET,
"/info", infoHandler});
On 2016/01/27 17:32:15, jcgregorio wrote:
> Shouldn't this be wired to /cmd since that's where the JSON for all the
> individual command comes from. The /info endpoint should just be high level
info
> like clip and CTM.

Acknowledged.

[jcgregorio, 2016-01-27 17:49:16]

lgtm

[joshualitt, 2016-01-27 17:49:27]

The CQ bit was checked by joshualitt@google.com

[commit-bot: I haz the power, 2016-01-27 17:49:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1640333002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1640333002/20001

[joshualitt, 2016-01-27 17:51:08]

The CQ bit was unchecked by joshualitt@google.com

[joshualitt, 2016-01-27 18:53:16]

The CQ bit was checked by joshualitt@google.com

[joshualitt, 2016-01-27 18:53:17]

The patchset sent to the CQ was uploaded after l-g-t-m from
jcgregorio@google.com
Link to the patchset: https://codereview.chromium.org/1640333002/#ps40001
(title: "add redirect")

[commit-bot: I haz the power, 2016-01-27 18:53:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1640333002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1640333002/40001

[commit-bot: I haz the power, 2016-01-27 19:07:25]

Description was changed from

==========
Wire up JsonCanvas in skiaserve

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Wire up JsonCanvas in skiaserve

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/609d97918788c077514f190b0f1087ccbd420f5d
==========

[commit-bot: I haz the power, 2016-01-27 19:07:26]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/609d97918788c077514f190b0f1087ccbd420f5d

[jcgregorio, 2016-01-27 19:21:19]

https://codereview.chromium.org/1640333002/diff/40001/tools/skiaserve/skiaser...
File tools/skiaserve/skiaserve.cpp (right):

https://codereview.chromium.org/1640333002/diff/40001/tools/skiaserve/skiaser...
tools/skiaserve/skiaserve.cpp:171: int ret = MHD_queue_response(connection,
MHD_HTTP_OK, response);
If it's a redirect the status code needs to be changed to a 303.