Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Issue 1640313002: Lazily create the Path in StylePath (Closed)

Created:
4 years, 11 months ago by fs
Modified:
4 years, 11 months ago
Reviewers:
pdr., Eric Willigers
CC:
blink-reviews, blink-reviews-style_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Lazily create the Path in StylePath Instead of creating the Path object up front - when the StylePath is created - create it on first access/use (usually on paint/layout.) Committed: https://crrev.com/e92b7c2b3facf65e3a9d1f2d07be0a916bdcf952 Cr-Commit-Position: refs/heads/master@{#371850}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -4 lines) Patch
M third_party/WebKit/Source/core/style/StylePath.h View 4 chunks +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/style/StylePath.cpp View 3 chunks +10 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
fs
Pondered this while looking at 'd' property perf regression. I don't that it'll be a ...
4 years, 11 months ago (2016-01-27 17:39:55 UTC) #2
pdr.
On 2016/01/27 at 17:39:55, fs wrote: > Pondered this while looking at 'd' property perf ...
4 years, 11 months ago (2016-01-27 19:38:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1640313002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1640313002/1
4 years, 11 months ago (2016-01-27 19:50:57 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-27 19:58:12 UTC) #6
commit-bot: I haz the power
4 years, 11 months ago (2016-01-27 19:59:55 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e92b7c2b3facf65e3a9d1f2d07be0a916bdcf952
Cr-Commit-Position: refs/heads/master@{#371850}

Powered by Google App Engine
This is Rietveld 408576698