Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 1640283004: Add trace events for ThreadedDataProvider (Closed)

Created:
4 years, 10 months ago by yhirano
Modified:
4 years, 10 months ago
Reviewers:
kinuko
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add trace events for ThreadedDataProvider This change adds trace events to ThreadedDataProvider. Even though the feature is still disabled by default, having trace events helps us investigate the behavior locally. BUG=581992, 277124 R=kinuko@chromium.org Committed: https://crrev.com/b0b23292ec53333f0e77d9604b9432bd4a60e357 Cr-Commit-Position: refs/heads/master@{#372054}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M content/child/threaded_data_provider.cc View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
yhirano
4 years, 10 months ago (2016-01-28 07:39:10 UTC) #4
kinuko
lgtm
4 years, 10 months ago (2016-01-28 08:03:15 UTC) #5
kinuko
On 2016/01/28 08:03:15, kinuko wrote: > lgtm Can you also add BUG=277124?
4 years, 10 months ago (2016-01-28 08:03:45 UTC) #6
yhirano
On 2016/01/28 08:03:45, kinuko wrote: > On 2016/01/28 08:03:15, kinuko wrote: > > lgtm > ...
4 years, 10 months ago (2016-01-28 08:07:06 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1640283004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1640283004/1
4 years, 10 months ago (2016-01-28 08:07:24 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-01-28 09:18:18 UTC) #12
commit-bot: I haz the power
4 years, 10 months ago (2016-01-28 09:19:24 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b0b23292ec53333f0e77d9604b9432bd4a60e357
Cr-Commit-Position: refs/heads/master@{#372054}

Powered by Google App Engine
This is Rietveld 408576698