Revert "Add an accessibility notification when new suggestions are shown."

Revert "Add an accessibility notification when new suggestions are shown."

This reverts commit 1602a2c9d3bffb19087140f22ac0b9462144e8d5.

This breaks VoiceOver as described in http://crbug.com/581813

BUG=581813
R=rohitrao@chromium.org,pkl@chromium.org

Committed: https://crrev.com/51c10f2256cc81207fd494f31a56df23bf594ba5
Cr-Commit-Position: refs/heads/master@{#372191}

[lpromero, 2016-01-28 01:40:16]

Proposing a revert first.

A solution needs to be found, it's not normal that the
-showCustomInputAccessoryView: is called when moving VoiceOver focus.

[lpromero, 2016-01-28 01:40:32]

lpromero@chromium.org changed reviewers:
+ jdonnelly@chromium.org

[Justin Donnelly, 2016-01-28 01:50:22]

lgtm

[pkl (ping after 24h if needed), 2016-01-28 05:45:25]

I patched the CL in and tested. It works a little better that navigation by
swiping right goes past the first screenful, but the page does not scroll with
the focus.

[lpromero, 2016-01-28 08:52:40]

On 2016/01/28 05:45:25, pklpkl wrote:
> I patched the CL in and tested. It works a little better that navigation by
> swiping right goes past the first screenful, but the page does not scroll with
> the focus.

Looks like another issue. I'll look into it.

[lpromero, 2016-01-28 16:15:15]

On 2016/01/28 08:52:40, lpromero wrote:
> On 2016/01/28 05:45:25, pklpkl wrote:
> > I patched the CL in and tested. It works a little better that navigation by
> > swiping right goes past the first screenful, but the page does not scroll
with
> > the focus.
> 
> Looks like another issue. I'll look into it.

Peter, the issue you describe is
https://code.google.com/p/chromium/issues/detail?id=581950.
Can we address them separately?

[lpromero, 2016-01-28 21:08:12]

Kindly ping on this one.

[pkl (ping after 24h if needed), 2016-01-28 21:47:40]

On 2016/01/28 21:08:12, lpromero wrote:
> Kindly ping on this one.

Yes. This CL makes VoiceOver navigation incrementally better than before, so
LGTM.

jdonnelly: does this unfix some other bugs that the rolled back commit was
supposed to fix?

[Justin Donnelly, 2016-01-28 21:53:26]

On 2016/01/28 21:47:40, pklpkl wrote:
> On 2016/01/28 21:08:12, lpromero wrote:
> > Kindly ping on this one.
> 
> Yes. This CL makes VoiceOver navigation incrementally better than before, so
> LGTM.
> 
> jdonnelly: does this unfix some other bugs that the rolled back commit was
> supposed to fix?

The change being reverted was intended to fix http://crbug.com/532721.
Unfortunately, as mentioned there, my change didn't actually fix the issue. So
it already needed further work. There's no downside to reverting this.

[rohitrao (ping after 24h), 2016-01-28 21:53:38]

lgtm

[lpromero, 2016-01-28 22:19:01]

The CQ bit was checked by lpromero@chromium.org

[commit-bot: I haz the power, 2016-01-28 22:20:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1640273003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1640273003/1

[commit-bot: I haz the power, 2016-01-28 22:29:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-28 22:29:29]

Failed to commit the patch.

[commit-bot: I haz the power, 2016-01-28 22:30:35]

The CQ bit was unchecked by commit-bot@chromium.org

[lpromero, 2016-01-28 22:33:02]

The CQ bit was checked by lpromero@chromium.org

[commit-bot: I haz the power, 2016-01-28 22:35:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1640273003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1640273003/1

[commit-bot: I haz the power, 2016-01-28 22:44:31]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-01-28 22:45:41]

Description was changed from

==========
Revert "Add an accessibility notification when new suggestions are shown."

This reverts commit 1602a2c9d3bffb19087140f22ac0b9462144e8d5.

This breaks VoiceOver as described in http://crbug.com/581813

BUG=581813
R=rohitrao@chromium.org,pkl@chromium.org
==========

to

==========
Revert "Add an accessibility notification when new suggestions are shown."

This reverts commit 1602a2c9d3bffb19087140f22ac0b9462144e8d5.

This breaks VoiceOver as described in http://crbug.com/581813

BUG=581813
R=rohitrao@chromium.org,pkl@chromium.org

Committed: https://crrev.com/51c10f2256cc81207fd494f31a56df23bf594ba5
Cr-Commit-Position: refs/heads/master@{#372191}
==========

[commit-bot: I haz the power, 2016-01-28 22:45:42]

Patchset 1 (id:??) landed as
https://crrev.com/51c10f2256cc81207fd494f31a56df23bf594ba5
Cr-Commit-Position: refs/heads/master@{#372191}