Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 1640263004: Revert of Let notifyScriptLoadError() handle already detached ScriptLoaders. (Closed)

Created:
4 years, 11 months ago by sof
Modified:
4 years, 11 months ago
Reviewers:
haraken
CC:
chromium-reviews, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Let notifyScriptLoadError() handle already detached ScriptLoaders. (patchset #3 id:40001 of https://codereview.chromium.org/1644483002/ ) Reason for revert: The change here assumes PendingScripts are separately allocated objects, an M50 change. This makes for more difficult backporting. Unnecessarily so. Hence reverting and will reland a variation ( https://codereview.chromium.org/1642863002/ ) that works for older branches. Original issue's description: > Let notifyScriptLoadError() handle already detached ScriptLoaders. > > If a ScriptRunner has been disposed of already, allow ScriptLoaders > to notify of their failure without asserting. > > R=haraken > BUG=570012 > > Committed: https://crrev.com/e7bf58190483dffac8e78506884170720165b198 > Cr-Commit-Position: refs/heads/master@{#371772} TBR=haraken@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=570012 Committed: https://crrev.com/51bab0b185b4c4ac4ef9ed62241e1b2ef9f8ca0a Cr-Commit-Position: refs/heads/master@{#372058}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -15 lines) Patch
M third_party/WebKit/Source/core/dom/ScriptLoader.h View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/dom/ScriptRunner.cpp View 1 chunk +2 lines, -12 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
sof
Created Revert of Let notifyScriptLoadError() handle already detached ScriptLoaders.
4 years, 11 months ago (2016-01-28 09:44:32 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1640263004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1640263004/1
4 years, 11 months ago (2016-01-28 09:44:58 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-28 09:45:54 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/51bab0b185b4c4ac4ef9ed62241e1b2ef9f8ca0a Cr-Commit-Position: refs/heads/master@{#372058}
4 years, 11 months ago (2016-01-28 09:46:46 UTC) #6
haraken
4 years, 11 months ago (2016-01-28 09:47:03 UTC) #7
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698