Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(506)

Unified Diff: chrome/browser/cocoa/toolbar_controller_unittest.mm

Issue 164024: Fix crash on fullscreening of popup. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/cocoa/toolbar_controller.mm ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/cocoa/toolbar_controller_unittest.mm
===================================================================
--- chrome/browser/cocoa/toolbar_controller_unittest.mm (revision 22550)
+++ chrome/browser/cocoa/toolbar_controller_unittest.mm (working copy)
@@ -84,6 +84,14 @@
EXPECT_NE(view, [bar_ view]);
EXPECT_FALSE([bar_ bookmarkBarController]);
+ // Simulate a popup going fullscreen and back.
+ NSView* superview = [view superview];
+ // TODO(jrg): find a way to add an [NSAutoreleasePool drain] in
+ // here. I don't have access to the current
+ // scoped_nsautorelease_pool to do it properly :-(
+ [view removeFromSuperview];
+ [superview addSubview:view];
+
[bar_ setHasToolbar:YES];
EXPECT_EQ(view, [bar_ view]);
EXPECT_TRUE([bar_ bookmarkBarController]);
« no previous file with comments | « chrome/browser/cocoa/toolbar_controller.mm ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698