Fix crash on fullscreening of popup.

chrome/browser/cocoa/toolbar_controller.mm

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/cocoa/toolbar_controller.h"
 
 #include "base/mac_util.h"
 #include "base/sys_string_conversions.h"
 #include "chrome/app/chrome_dll_resource.h"
 #import "chrome/browser/cocoa/autocomplete_text_field.h"
@@ skipping 101 matching lines @@
                                         parentView:[self view]
                                     webContentView:webContentView_
                                       infoBarsView:infoBarsView_
                                           delegate:bookmarkBarDelegate_]);
 
   // Add bookmark bar to the view hierarchy.  This also triggers the
   // nib load.  The bookmark bar is defined (in the nib) to be
   // bottom-aligned to it's parent view (among other things), so
   // position and resize properties don't need to be set.
   [[self view] addSubview:[bookmarkBarController_ view]];
+
+  // For a popup window, the toolbar is really just a location bar
+  // (see override for [ToolbarController view], below).  When going
+  // fullscreen, we remove the toolbar controller's view from the view
+  // hierarchy.  Calling [locationBar_ removeFromSuperview] when going
+  // fullscreen causes it to get released, making us unhappy
+  // (http://crbug.com/18551).  We avoid the problem by incrementing
+  // the retain count of the location bar; use of the scoped object
+  // helps us remember to release it.
+  locationBarRetainer_.reset([locationBar_ retain]);
 }
 
 - (LocationBar*)locationBar {
   return locationBarView_.get();
 }
 
 - (void)focusLocationBar {
   if (locationBarView_.get()) {
     locationBarView_->FocusLocation();
   }
@@ skipping 188 matching lines @@
                    forView:pageButton_];
 }
 
 - (IBAction)showWrenchMenu:(id)sender {
   [NSMenu popUpContextMenu:wrenchMenu_
                  withEvent:[NSApp currentEvent]
                    forView:wrenchButton_];
 }
 
 @end